From: Gerd Hoffmann <kraxel@redhat.com>
To: Gonglei <arei.gonglei@huawei.com>
Cc: qemu-trivial@nongnu.org, Hans de Goede <hdegoede@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] xhci: remove unused code
Date: Tue, 05 May 2015 11:55:10 +0200 [thread overview]
Message-ID: <1430819710.28106.5.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <55408699.5030201@huawei.com>
Hi,
> > So, I think if we were to drop this assignment, we should
> > remove the initializer too. But before doing this, I think
> > we should try to remember _why_ this assignment is here in
> > the first place. The code looks like after the loop, this
> > ep variable was supposed to be used for something. Or is
> > it just a leftover from 518ad5f2a075 (Cc'ing the author)?
> >
> I can't agree with you more. :)
Yes, certainly looks like a 518ad5f2a075 leftover.
Should be ok to cleanup.
cheers,
Gerd
next prev parent reply other threads:[~2015-05-05 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 9:11 [Qemu-devel] [PATCH 0/3] trivial patches arei.gonglei
2015-04-28 9:11 ` [Qemu-devel] [PATCH 1/3] target-mips: fix memory leak arei.gonglei
2015-04-28 11:46 ` Leon Alrae
2015-04-28 9:11 ` [Qemu-devel] [PATCH 2/3] xhci: remove unused code arei.gonglei
2015-04-29 6:48 ` Michael Tokarev
2015-04-29 7:22 ` Gonglei
2015-05-05 9:55 ` Gerd Hoffmann [this message]
2015-05-05 10:18 ` Michael Tokarev
2015-04-28 9:11 ` [Qemu-devel] [PATCH 3/3] vhost-user: remove superfluous '\n' around error_report() arei.gonglei
2015-04-28 12:08 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430819710.28106.5.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=hdegoede@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).