From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpZel-0002JU-WF for qemu-devel@nongnu.org; Tue, 05 May 2015 06:01:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpZeQ-0000rJ-T2 for qemu-devel@nongnu.org; Tue, 05 May 2015 06:00:51 -0400 Message-ID: <1430819710.28106.5.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 05 May 2015 11:55:10 +0200 In-Reply-To: <55408699.5030201@huawei.com> References: <1430212264-9672-1-git-send-email-arei.gonglei@huawei.com> <1430212264-9672-3-git-send-email-arei.gonglei@huawei.com> <55407ED3.102@msgid.tls.msk.ru> <55408699.5030201@huawei.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] xhci: remove unused code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: qemu-trivial@nongnu.org, Hans de Goede , Michael Tokarev , qemu-devel@nongnu.org Hi, > > So, I think if we were to drop this assignment, we should > > remove the initializer too. But before doing this, I think > > we should try to remember _why_ this assignment is here in > > the first place. The code looks like after the loop, this > > ep variable was supposed to be used for something. Or is > > it just a leftover from 518ad5f2a075 (Cc'ing the author)? > > > I can't agree with you more. :) Yes, certainly looks like a 518ad5f2a075 leftover. Should be ok to cleanup. cheers, Gerd