[Qemu-devel] [PATCH 0/6] trivial fixes

[Qemu-devel] [PATCH 0/6] trivial fixes

[Emilio G. Cota]

Here is a hodge-podge of fixes for issues I found while reviewing
QTAILQ callers, with a .gitignore patch as a bonus.

Thanks,

		Emilio

[Qemu-devel] [PATCH 1/6] cpus: use first_cpu macro instead of QTAILQ_FIRST(&cpus)

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 cpus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cpus.c b/cpus.c
index e6dcae3..62d157a 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1016,7 +1016,7 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
     qemu_cond_signal(&qemu_cpu_cond);
 
     /* wait for initial kick-off after machine start */
-    while (QTAILQ_FIRST(&cpus)->stopped) {
+    while (first_cpu->stopped) {
         qemu_cond_wait(tcg_halt_cond, &qemu_global_mutex);
 
         /* process any pending work */
-- 
1.9.1

[Qemu-devel] [PATCH 2/6] input: remove unused mouse_handlers list

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 ui/input-legacy.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ui/input-legacy.c b/ui/input-legacy.c
index 2d4ca19..3e9bb38 100644
--- a/ui/input-legacy.c
+++ b/ui/input-legacy.c
@@ -57,8 +57,6 @@ struct QEMUPutLEDEntry {
 
 static QTAILQ_HEAD(, QEMUPutLEDEntry) led_handlers =
     QTAILQ_HEAD_INITIALIZER(led_handlers);
-static QTAILQ_HEAD(, QEMUPutMouseEntry) mouse_handlers =
-    QTAILQ_HEAD_INITIALIZER(mouse_handlers);
 
 int index_from_key(const char *key)
 {
-- 
1.9.1

Re: [Qemu-devel] [PATCH 2/6] input: remove unused mouse_handlers list

[Gerd Hoffmann]

On Mo, 2015-04-27 at 12:45 -0400, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota <cota@braap.org>

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Re: [Qemu-devel] [PATCH 2/6] input: remove unused mouse_handlers list

[Michael Tokarev]

05.05.2015 13:00, Gerd Hoffmann wrote:
> On Mo, 2015-04-27 at 12:45 -0400, Emilio G. Cota wrote:
>> Signed-off-by: Emilio G. Cota <cota@braap.org>
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Too late, it has already been applied to master…

/mjt

[Qemu-devel] [PATCH 3/6] qemu-char: remove unused list node from FDCharDriver

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 qemu-char.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/qemu-char.c b/qemu-char.c
index a405d76..d0c1564 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -973,7 +973,6 @@ typedef struct FDCharDriver {
     CharDriverState *chr;
     GIOChannel *fd_in, *fd_out;
     int max_size;
-    QTAILQ_ENTRY(FDCharDriver) node;
 } FDCharDriver;
 
 /* Called with chr_write_lock held.  */
-- 
1.9.1

[Qemu-devel] [PATCH 4/6] gitignore: ignore *.patch files

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index aed0e1f..025a841 100644
--- a/.gitignore
+++ b/.gitignore
@@ -62,6 +62,7 @@
 *.fn
 *.ky
 *.log
+*.patch
 *.pdf
 *.pod
 *.cps
-- 
1.9.1

Re: [Qemu-devel] [PATCH 4/6] gitignore: ignore *.patch files

[Peter Crosthwaite]

On Mon, Apr 27, 2015 at 9:45 AM, Emilio G. Cota <cota@braap.org> wrote:
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index aed0e1f..025a841 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -62,6 +62,7 @@
>  *.fn
>  *.ky
>  *.log
> +*.patch

This Issue is discussed and I think it was concluded to not gitignore
patches. See:

commit f3a22014e94dfaacb57277dafce66b41cd994869
Author: Michael Tokarev <mjt@tls.msk.ru>
Date:   Thu Jun 6 01:14:54 2013 +0400

    gitignore: unignore *.patch

    This partially reverts:

     commit 082369e62c5bbaba89f173c2b803bc24115bb111
     Author: liguang <lig.fnst@cn.fujitsu.com>
     Date:   Fri Mar 22 16:44:13 2013 +0800

        gitignore: ignore more files

    I'm not sure how this went in.  The thing is that
    ignoring *.patch, in my opinion, is just wrong.
    Especially for downstreams who apply patches for
    real.

    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


Regards,
Peter


>  *.pdf
>  *.pod
>  *.cps
> --
> 1.9.1
>
>

Re: [Qemu-devel] [PATCH 4/6] gitignore: ignore *.patch files

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

On 04/27/2015 12:11 PM, Peter Crosthwaite wrote:

>> +++ b/.gitignore
>> @@ -62,6 +62,7 @@
>>  *.fn
>>  *.ky
>>  *.log
>> +*.patch
> 
> This Issue is discussed and I think it was concluded to not gitignore
> patches. See:
> 
> commit f3a22014e94dfaacb57277dafce66b41cd994869
> Author: Michael Tokarev <mjt@tls.msk.ru>
> Date:   Thu Jun 6 01:14:54 2013 +0400
> 
>     gitignore: unignore *.patch

You can always ignore them locally:
echo '*.patch' >> .git/info/exclude

without requiring everyone to ignore them (I actually like seeing them
show up, to know when I have not yet hit send on a series).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH 4/6] gitignore: ignore *.patch files

[Emilio G. Cota]

On Mon, Apr 27, 2015 at 12:28:00 -0600, Eric Blake wrote:
> On 04/27/2015 12:11 PM, Peter Crosthwaite wrote:
> > This Issue is discussed and I think it was concluded to not gitignore
> > patches. See:
> > 
> > commit f3a22014e94dfaacb57277dafce66b41cd994869
> > Author: Michael Tokarev <mjt@tls.msk.ru>
> > Date:   Thu Jun 6 01:14:54 2013 +0400
> > 
> >     gitignore: unignore *.patch
> 
> You can always ignore them locally:
> echo '*.patch' >> .git/info/exclude
> 
> without requiring everyone to ignore them (I actually like seeing them
> show up, to know when I have not yet hit send on a series).

Thanks for the tip!

All: please ignore this patch in the series.

		Emilio

[Qemu-devel] [PATCH 5/6] coroutine: remove unnecessary parentheses in qemu_co_queue_empty

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 qemu-coroutine-lock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c
index e4860ae..6b49033 100644
--- a/qemu-coroutine-lock.c
+++ b/qemu-coroutine-lock.c
@@ -108,7 +108,7 @@ bool qemu_co_enter_next(CoQueue *queue)
 
 bool qemu_co_queue_empty(CoQueue *queue)
 {
-    return (QTAILQ_FIRST(&queue->entries) == NULL);
+    return QTAILQ_FIRST(&queue->entries) == NULL;
 }
 
 void qemu_co_mutex_init(CoMutex *mutex)
-- 
1.9.1

[Qemu-devel] [PATCH 6/6] linux-user/elfload: use QTAILQ_FOREACH instead of open-coding it

[Emilio G. Cota]

Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 linux-user/elfload.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 399c021..0ba9706 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2887,8 +2887,7 @@ static int write_note_info(struct elf_note_info *info, int fd)
             return (error);
 
     /* write prstatus for each thread */
-    for (ets = info->thread_list.tqh_first; ets != NULL;
-         ets = ets->ets_link.tqe_next) {
+    QTAILQ_FOREACH(ets, &info->thread_list, ets_link) {
         if ((error = write_note(&ets->notes[0], fd)) != 0)
             return (error);
     }
-- 
1.9.1

Re: [Qemu-devel] [PATCH 0/6] trivial fixes

[Michael Tokarev]

27.04.2015 19:45, Emilio G. Cota wrote:
> Here is a hodge-podge of fixes for issues I found while reviewing
> QTAILQ callers, with a .gitignore patch as a bonus.

Applied to -trivial, all except the bonus.  The 5/6 one (unnecessary
parentheses removal) is a bit too trivial, maybe not worh a patch, but
I applied it too anyway.

Thank you!

/mjt