From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpxRC-0005f1-0I for qemu-devel@nongnu.org; Wed, 06 May 2015 07:24:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpxRB-0003Vk-74 for qemu-devel@nongnu.org; Wed, 06 May 2015 07:24:25 -0400 From: Fam Zheng Date: Wed, 6 May 2015 19:23:39 +0800 Message-Id: <1430911419-8256-8-git-send-email-famz@redhat.com> In-Reply-To: <1430911419-8256-1-git-send-email-famz@redhat.com> References: <1430911419-8256-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [RFC PATCH 7/7] blockdev: Add "device IO" op blocker during snapshot transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, jcody@redhat.com, armbru@redhat.com, mreitz@redhat.com, Stefan Hajnoczi , pbonzini@redhat.com Signed-off-by: Fam Zheng --- blockdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..859fa2e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1398,6 +1398,7 @@ typedef struct ExternalSnapshotState { BlockDriverState *old_bs; BlockDriverState *new_bs; AioContext *aio_context; + Error *blocker; } ExternalSnapshotState; static void external_snapshot_prepare(BlkTransactionState *common, @@ -1519,6 +1520,9 @@ static void external_snapshot_prepare(BlkTransactionState *common, if (ret != 0) { error_propagate(errp, local_err); } + + error_setg(&state->blocker, "snapshot in progress"); + bdrv_op_block(state->old_bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker); } static void external_snapshot_commit(BlkTransactionState *common) @@ -1536,6 +1540,9 @@ static void external_snapshot_commit(BlkTransactionState *common) bdrv_reopen(state->new_bs, state->new_bs->open_flags & ~BDRV_O_RDWR, NULL); + bdrv_op_unblock(state->old_bs, BLOCK_OP_TYPE_DEVICE_IO, state->blocker); + error_free(state->blocker); + aio_context_release(state->aio_context); } -- 1.9.3