qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yossi Hindin <yhindin@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, Yossi Hindin <yhindin@redhat.com>,
	mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [Patch V2 1/4] qemu-ga: adding vss-[un]install options
Date: Wed,  6 May 2015 14:57:37 +0300	[thread overview]
Message-ID: <1430913460-13174-2-git-send-email-yhindin@redhat.com> (raw)
In-Reply-To: <1430913460-13174-1-git-send-email-yhindin@redhat.com>

Existing command line options include '-s install' and '-s uninstall'.
These options install/uninstall both Windows QEMU GA service
and optional VSS COM server. The QEMU GA Windows service allows
always-on serving guest agent's QMP commands and VSS COM server
enables guest agent integration with Volume Shadow Service.

This commit introdices new options '-s vss-install' and '-s vss-uninstall',
affecting only GA VSS COM server registration. The new options are useful
for registering and unregistering the COM server during MSI installation,
upgrade and uninstallation.

Signed-off-by: Yossi Hindin <yhindin@redhat.com>
---
 qga/main.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/qga/main.c b/qga/main.c
index 9939a2b..7e1e438 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -211,7 +211,7 @@ static void usage(const char *cmd)
 "  -V, --version     print version information and exit\n"
 "  -d, --daemonize   become a daemon\n"
 #ifdef _WIN32
-"  -s, --service     service commands: install, uninstall\n"
+"  -s, --service     service commands: install, uninstall, vss-install, vss-uninstall\n"
 #endif
 "  -b, --blacklist   comma-separated list of RPCs to disable (no spaces, \"?\"\n"
 "                    to list available RPCs)\n"
@@ -1036,6 +1036,14 @@ int main(int argc, char **argv)
             } else if (strcmp(service, "uninstall") == 0) {
                 ga_uninstall_vss_provider();
                 return ga_uninstall_service();
+            } else if (strcmp(service, "vss-install") == 0) {
+                if (ga_install_vss_provider()) {
+                    return EXIT_FAILURE;
+                }
+                return EXIT_SUCCESS;
+            } else if (strcmp(service, "vss-uninstall") == 0) {
+                ga_uninstall_vss_provider();
+                return EXIT_SUCCESS;
             } else {
                 printf("Unknown service command.\n");
                 return EXIT_FAILURE;
-- 
2.1.0

  reply	other threads:[~2015-05-06 11:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 11:57 [Qemu-devel] [Patch V2 0/4] [Patch V2 0/4] Windows MSI installation package Yossi Hindin
2015-05-06 11:57 ` Yossi Hindin [this message]
2015-05-06 11:57 ` [Qemu-devel] [Patch V2 2/4] qemu-ga: debug printouts to help troubleshoot installation Yossi Hindin
2015-05-06 11:57 ` [Qemu-devel] [Patch V2 3/4] qemu-ga: Introduce Windows MSI script Yossi Hindin
2015-05-06 11:57 ` [Qemu-devel] [Patch V2 4/4] qemu-ga: Building Windows MSI installation with configure/Makefile Yossi Hindin
2015-05-06 14:14 ` [Qemu-devel] [Patch V2 0/4] [Patch V2 0/4] Windows MSI installation package Paolo Bonzini
2015-06-04 15:00   ` Yan Vugenfirer
2015-06-17 13:25 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430913460-13174-2-git-send-email-yhindin@redhat.com \
    --to=yhindin@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).