qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Leon Alrae <leon.alrae@imgtec.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, christopher.covington@linaro.org,
	matthew.fortune@imgtec.com, ilg@livius.net
Subject: [Qemu-devel] [PATCH 3/4] semihosting: create SemihostingConfig struct
Date: Wed, 6 May 2015 15:57:08 +0100	[thread overview]
Message-ID: <1430924229-20469-4-git-send-email-leon.alrae@imgtec.com> (raw)
In-Reply-To: <1430924229-20469-1-git-send-email-leon.alrae@imgtec.com>

Group semihosting config related variables in a single structure.

Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
---
 vl.c | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/vl.c b/vl.c
index a42f127..82586c7 100644
--- a/vl.c
+++ b/vl.c
@@ -1227,17 +1227,21 @@ static void configure_msg(QemuOpts *opts)
 /***********************************************************/
 /* Semihosting */
 
-static bool semihosting_allowed;
-static SemihostingTarget semihosting_target;
+typedef struct SemihostingConfig {
+    bool allowed;
+    SemihostingTarget target;
+} SemihostingConfig;
+
+static SemihostingConfig semihosting;
 
 bool semihosting_enabled(void)
 {
-    return semihosting_allowed;
+    return semihosting.allowed;
 }
 
 SemihostingTarget semihosting_get_target(void)
 {
-    return semihosting_target;
+    return semihosting.target;
 }
 
 /***********************************************************/
@@ -3561,24 +3565,24 @@ int main(int argc, char **argv, char **envp)
                 nb_option_roms++;
                 break;
             case QEMU_OPTION_semihosting:
-                semihosting_allowed = true;
-                semihosting_target = SEMIHOSTING_TARGET_AUTO;
+                semihosting.allowed = true;
+                semihosting.target = SEMIHOSTING_TARGET_AUTO;
                 break;
             case QEMU_OPTION_semihosting_config:
-                semihosting_allowed = true;
+                semihosting.allowed = true;
                 opts = qemu_opts_parse(qemu_find_opts("semihosting-config"),
                                            optarg, 0);
                 if (opts != NULL) {
-                    semihosting_allowed = qemu_opt_get_bool(opts, "enable",
+                    semihosting.allowed = qemu_opt_get_bool(opts, "enable",
                                                             true);
                     const char *target = qemu_opt_get(opts, "target");
                     if (target != NULL) {
                         if (strcmp("native", target) == 0) {
-                            semihosting_target = SEMIHOSTING_TARGET_NATIVE;
+                            semihosting.target = SEMIHOSTING_TARGET_NATIVE;
                         } else if (strcmp("gdb", target) == 0) {
-                            semihosting_target = SEMIHOSTING_TARGET_GDB;
+                            semihosting.target = SEMIHOSTING_TARGET_GDB;
                         } else  if (strcmp("auto", target) == 0) {
-                            semihosting_target = SEMIHOSTING_TARGET_AUTO;
+                            semihosting.target = SEMIHOSTING_TARGET_AUTO;
                         } else {
                             fprintf(stderr, "Unsupported semihosting-config"
                                     " %s\n",
@@ -3586,7 +3590,7 @@ int main(int argc, char **argv, char **envp)
                             exit(1);
                         }
                     } else {
-                        semihosting_target = SEMIHOSTING_TARGET_AUTO;
+                        semihosting.target = SEMIHOSTING_TARGET_AUTO;
                     }
                 } else {
                     fprintf(stderr, "Unsupported semihosting-config %s\n",

  parent reply	other threads:[~2015-05-06 14:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 14:57 [Qemu-devel] [PATCH 0/4] semihosting: clean up and add --semihosting-config arg Leon Alrae
2015-05-06 14:57 ` [Qemu-devel] [PATCH 1/4] semihosting: remove semihosting_enabled declaration from sysemu.h Leon Alrae
2015-05-06 14:57 ` [Qemu-devel] [PATCH 2/4] semihosting: remove semihosting_target declaration from gdbstub.h Leon Alrae
2015-05-06 14:57 ` Leon Alrae [this message]
2015-05-06 14:57 ` [Qemu-devel] [PATCH 4/4] semihosting: add --semihosting-config arg sub-argument Leon Alrae
2015-05-07  6:51   ` Liviu Ionescu
2015-05-07  9:52     ` Leon Alrae
2015-05-07 11:50       ` Liviu Ionescu
2015-05-07 12:21         ` Leon Alrae
2015-05-07 12:35           ` Liviu Ionescu
2015-05-07 12:42             ` Leon Alrae
2015-05-06 15:22 ` [Qemu-devel] [PATCH 0/4] semihosting: clean up and add --semihosting-config arg Liviu Ionescu
2015-05-06 16:12   ` Leon Alrae
2015-05-13  5:48     ` Liviu Ionescu
2015-05-13  9:29       ` Leon Alrae
2015-05-13  9:44         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430924229-20469-4-git-send-email-leon.alrae@imgtec.com \
    --to=leon.alrae@imgtec.com \
    --cc=christopher.covington@linaro.org \
    --cc=ilg@livius.net \
    --cc=matthew.fortune@imgtec.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).