From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqG9X-0005sG-CG for qemu-devel@nongnu.org; Thu, 07 May 2015 03:23:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqG9S-0007m1-CO for qemu-devel@nongnu.org; Thu, 07 May 2015 03:23:27 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:35014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqG9R-0007ls-O4 for qemu-devel@nongnu.org; Thu, 07 May 2015 03:23:22 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 May 2015 17:23:20 +1000 From: Nikunj A Dadhania Date: Thu, 7 May 2015 12:51:52 +0530 Message-Id: <1430983314-5009-3-git-send-email-nikunj@linux.vnet.ibm.com> In-Reply-To: <1430983314-5009-1-git-send-email-nikunj@linux.vnet.ibm.com> References: <1430983314-5009-1-git-send-email-nikunj@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v4 2/4] spapr_pci: encode class code including Prog IF register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, david@gibson.dropbear.id.au Cc: Nikunj A Dadhania , aik@ozlabs.ru, agraf@suse.de, mdroth@linux.vnet.ibm.com, nikunj.dadhania@gmail.com, qemu-ppc@nongnu.org Current code missed the Prog IF register. All Class Code, Subclass, and Prog IF registers are needed to identify the accurate device type. For example: USB controllers use the PROG IF for denoting: USB FullSpeed, HighSpeed or SuperSpeed. Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- hw/ppc/spapr_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index ea1a092..8b02a3e 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -899,8 +899,7 @@ static int spapr_populate_pci_child_dt(PCIDevice *dev, void *fdt, int offset, _FDT(fdt_setprop_cell(fdt, offset, "revision-id", pci_default_read_config(dev, PCI_REVISION_ID, 1))); _FDT(fdt_setprop_cell(fdt, offset, "class-code", - pci_default_read_config(dev, PCI_CLASS_DEVICE, 2) - << 8)); + pci_default_read_config(dev, PCI_CLASS_PROG, 3))); if (pci_default_read_config(dev, PCI_INTERRUPT_PIN, 1)) { _FDT(fdt_setprop_cell(fdt, offset, "interrupts", pci_default_read_config(dev, PCI_INTERRUPT_PIN, 1))); -- 1.8.3.1