From: Zhe Qiu <phoeagon@gmail.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Zhe Qiu <phoeagon@gmail.com>,
qemu-block@nongnu.org, sw@weilnetz.de, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates
Date: Thu, 7 May 2015 23:16:58 +0800 [thread overview]
Message-ID: <1431011818-15822-1-git-send-email-phoeagon@gmail.com> (raw)
In-Reply-To: <1430971496-32659-1-git-send-email-phoeagon@gmail.com>
In reference to b0ad5a45...078a458e, metadata writes to
qcow2/cow/qcow/vpc/vmdk are all synced prior to succeeding writes.
Only when write is successful that bdrv_flush is called.
Signed-off-by: Zhe Qiu <phoeagon@gmail.com>
---
block/vdi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/vdi.c b/block/vdi.c
index 7642ef3..dfe8ade 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -713,6 +713,9 @@ static int vdi_co_write(BlockDriverState *bs,
logout("will write %u block map sectors starting from entry %u\n",
n_sectors, bmap_first);
ret = bdrv_write(bs->file, offset, base, n_sectors);
+ if (ret >= 0) {
+ ret = bdrv_flush(bs->file);
+ }
}
return ret;
--
2.4.0
next prev parent reply other threads:[~2015-05-07 15:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 4:04 [Qemu-devel] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates Zhe Qiu
2015-05-07 10:09 ` Stefan Hajnoczi
2015-05-07 15:05 ` [Qemu-devel] [Qemu-block] " Eric Blake
2015-05-07 15:16 ` Zhe Qiu [this message]
2015-05-08 13:14 ` [Qemu-devel] [PATCH v4] " Max Reitz
2015-05-08 13:55 ` Kevin Wolf
2015-05-08 14:43 ` phoeagon
2015-05-08 21:26 ` Stefan Weil
2015-05-09 3:54 ` phoeagon
2015-05-09 3:59 ` phoeagon
2015-05-09 6:39 ` Stefan Weil
2015-05-09 7:41 ` phoeagon
2015-05-10 15:01 ` Paolo Bonzini
2015-05-10 16:02 ` Stefan Weil
2015-05-10 16:05 ` phoeagon
2015-05-10 16:10 ` Paolo Bonzini
2015-05-10 16:26 ` Stefan Weil
2015-05-10 17:14 ` phoeagon
2015-05-08 10:43 ` [Qemu-devel] [Qemu-block] [PATCH v3] " Kevin Wolf
2015-05-08 11:50 ` phoeagon
2015-05-08 12:02 ` Kevin Wolf
2015-05-08 12:56 ` phoeagon
2015-05-08 13:10 ` [Qemu-devel] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431011818-15822-1-git-send-email-phoeagon@gmail.com \
--to=phoeagon@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).