* [Qemu-devel] [PATCH] migration: Fix migration state update issue
@ 2015-05-07 18:31 Liang Li
2015-05-07 11:38 ` Dr. David Alan Gilbert
2015-05-07 11:38 ` Juan Quintela
0 siblings, 2 replies; 3+ messages in thread
From: Liang Li @ 2015-05-07 18:31 UTC (permalink / raw)
To: qemu-devel; +Cc: amit.shah, yang.z.zhang, Liang Li, quintela
If live migration is very fast and can be completed in 1 second,
the dirty_sync_count of MigrationState will not be updated.
Then you will see "dirty sync count: 0" in qemu monitor even if
the actual dirty sync count is not 0.
Signed-off-by: Liang Li <liang.z.li@intel.com>
---
arch_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch_init.c b/arch_init.c
index 4c8fcee..a48f575 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -599,8 +599,8 @@ static void migration_bitmap_sync(void)
s->dirty_bytes_rate = s->dirty_pages_rate * TARGET_PAGE_SIZE;
start_time = end_time;
num_dirty_pages_period = 0;
- s->dirty_sync_count = bitmap_sync_count;
}
+ s->dirty_sync_count = bitmap_sync_count;
}
/**
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] migration: Fix migration state update issue
2015-05-07 18:31 [Qemu-devel] [PATCH] migration: Fix migration state update issue Liang Li
@ 2015-05-07 11:38 ` Dr. David Alan Gilbert
2015-05-07 11:38 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2015-05-07 11:38 UTC (permalink / raw)
To: Liang Li; +Cc: amit.shah, yang.z.zhang, qemu-devel, quintela
* Liang Li (liang.z.li@intel.com) wrote:
> If live migration is very fast and can be completed in 1 second,
> the dirty_sync_count of MigrationState will not be updated.
> Then you will see "dirty sync count: 0" in qemu monitor even if
> the actual dirty sync count is not 0.
>
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> ---
> arch_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index 4c8fcee..a48f575 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -599,8 +599,8 @@ static void migration_bitmap_sync(void)
> s->dirty_bytes_rate = s->dirty_pages_rate * TARGET_PAGE_SIZE;
> start_time = end_time;
> num_dirty_pages_period = 0;
> - s->dirty_sync_count = bitmap_sync_count;
> }
> + s->dirty_sync_count = bitmap_sync_count;
> }
Yes, makes sense.
(An interesting question is why there needs to be a separate bitmap_sync_count
variable that's separate from s->dirty_sync_count)
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Dave
>
> /**
> --
> 1.9.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: Fix migration state update issue
2015-05-07 18:31 [Qemu-devel] [PATCH] migration: Fix migration state update issue Liang Li
2015-05-07 11:38 ` Dr. David Alan Gilbert
@ 2015-05-07 11:38 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Juan Quintela @ 2015-05-07 11:38 UTC (permalink / raw)
To: Liang Li; +Cc: amit.shah, yang.z.zhang, qemu-devel
Liang Li <liang.z.li@intel.com> wrote:
> If live migration is very fast and can be completed in 1 second,
> the dirty_sync_count of MigrationState will not be updated.
> Then you will see "dirty sync count: 0" in qemu monitor even if
> the actual dirty sync count is not 0.
>
> Signed-off-by: Liang Li <liang.z.li@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Added to new pull request, thanks.
> ---
> arch_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index 4c8fcee..a48f575 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -599,8 +599,8 @@ static void migration_bitmap_sync(void)
> s->dirty_bytes_rate = s->dirty_pages_rate * TARGET_PAGE_SIZE;
> start_time = end_time;
> num_dirty_pages_period = 0;
> - s->dirty_sync_count = bitmap_sync_count;
> }
> + s->dirty_sync_count = bitmap_sync_count;
> }
>
> /**
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-07 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-07 18:31 [Qemu-devel] [PATCH] migration: Fix migration state update issue Liang Li
2015-05-07 11:38 ` Dr. David Alan Gilbert
2015-05-07 11:38 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).