qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gonglei <arei.gonglei@huawei.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 09/19] usb: usb-hub QOMify
Date: Fri,  8 May 2015 13:45:43 +0200	[thread overview]
Message-ID: <1431085553-6055-10-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1431085553-6055-1-git-send-email-kraxel@redhat.com>

From: Gonglei <arei.gonglei@huawei.com>

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/dev-hub.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c
index 0482f58..c8c6855 100644
--- a/hw/usb/dev-hub.c
+++ b/hw/usb/dev-hub.c
@@ -41,6 +41,9 @@ typedef struct USBHubState {
     USBHubPort ports[NUM_PORTS];
 } USBHubState;
 
+#define TYPE_USB_HUB "usb-hub"
+#define USB_HUB(obj) OBJECT_CHECK(USBHubState, (obj), TYPE_USB_HUB)
+
 #define ClearHubFeature		(0x2000 | USB_REQ_CLEAR_FEATURE)
 #define ClearPortFeature	(0x2300 | USB_REQ_CLEAR_FEATURE)
 #define GetHubDescriptor	(0xa000 | USB_REQ_GET_DESCRIPTOR)
@@ -227,7 +230,7 @@ static void usb_hub_complete(USBPort *port, USBPacket *packet)
 
 static USBDevice *usb_hub_find_device(USBDevice *dev, uint8_t addr)
 {
-    USBHubState *s = DO_UPCAST(USBHubState, dev, dev);
+    USBHubState *s = USB_HUB(dev);
     USBHubPort *port;
     USBDevice *downstream;
     int i;
@@ -247,7 +250,7 @@ static USBDevice *usb_hub_find_device(USBDevice *dev, uint8_t addr)
 
 static void usb_hub_handle_reset(USBDevice *dev)
 {
-    USBHubState *s = DO_UPCAST(USBHubState, dev, dev);
+    USBHubState *s = USB_HUB(dev);
     USBHubPort *port;
     int i;
 
@@ -513,7 +516,7 @@ static USBPortOps usb_hub_port_ops = {
 
 static void usb_hub_realize(USBDevice *dev, Error **errp)
 {
-    USBHubState *s = DO_UPCAST(USBHubState, dev, dev);
+    USBHubState *s = USB_HUB(dev);
     USBHubPort *port;
     int i;
 
@@ -577,7 +580,7 @@ static void usb_hub_class_initfn(ObjectClass *klass, void *data)
 }
 
 static const TypeInfo hub_info = {
-    .name          = "usb-hub",
+    .name          = TYPE_USB_HUB,
     .parent        = TYPE_USB_DEVICE,
     .instance_size = sizeof(USBHubState),
     .class_init    = usb_hub_class_initfn,
-- 
1.8.3.1

  parent reply	other threads:[~2015-05-08 11:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 11:45 [Qemu-devel] [PULL 00/19] usb: qomify, bugfixes for xhci & uhci Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 01/19] usb: fix usb-net segfault Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 02/19] xhci: set timer to retry xfers Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 03/19] Revert "xhci: generate a Transfer Event for each Transfer TRB with the IOC bit set" Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 04/19] xhci: fix events for setup trb Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 05/19] uhci: QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 06/19] usb: usb-audio QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 07/19] usb: usb-bt QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 08/19] usb: usb-hid QOMify Gerd Hoffmann
2015-05-08 11:45 ` Gerd Hoffmann [this message]
2015-05-08 11:45 ` [Qemu-devel] [PULL 10/19] usb: usb-mtp QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 11/19] usb-mtp: fix segmentation fault Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 12/19] usb: usb-net QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 13/19] usb: usb-ccid QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 14/19] usb: usb-storage QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 15/19] usb: usb-uas QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 16/19] usb: usb-wacom-tablet QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 17/19] usb: usb-redir QOMify Gerd Hoffmann
2015-05-08 11:45 ` [Qemu-devel] [PULL 18/19] usb: usb-serial QOMify Gerd Hoffmann
2015-05-10 22:18   ` Samuel Thibault
2015-05-08 11:45 ` [Qemu-devel] [PULL 19/19] uhci: controller is halted after reset Gerd Hoffmann
2015-05-11  9:42 ` [Qemu-devel] [PULL 00/19] usb: qomify, bugfixes for xhci & uhci Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431085553-6055-10-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).