From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yri56-0007gl-NM for qemu-devel@nongnu.org; Mon, 11 May 2015 03:24:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yri53-0003bk-6f for qemu-devel@nongnu.org; Mon, 11 May 2015 03:24:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yri53-0003bY-18 for qemu-devel@nongnu.org; Mon, 11 May 2015 03:24:49 -0400 From: Markus Armbruster Date: Mon, 11 May 2015 09:24:39 +0200 Message-Id: <1431329083-32543-6-git-send-email-armbru@redhat.com> In-Reply-To: <1431329083-32543-1-git-send-email-armbru@redhat.com> References: <1431329083-32543-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 5/9] qapi: Fix generators to report command line errors decently List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com Report to stderr, prefix with the program name. Also reject extra arguments. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index d90a538..5807476 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -971,7 +971,7 @@ def parse_command_line(extra_options = "", extra_long_options = []): "input-file=", "output-dir="] + extra_long_options) except getopt.GetoptError, err: - print str(err) + print >>sys.stderr, "%s: %s" % (sys.argv[0], str(err)) sys.exit(1) output_dir = "" @@ -999,4 +999,8 @@ def parse_command_line(extra_options = "", extra_long_options = []): do_c = True do_h = True + if len(args) != 0: + print >>sys.stderr, "%s: too many arguments"% sys.argv[0] + sys.exit(1) + return (input_file, output_dir, do_c, do_h, prefix, extra_opts) -- 1.9.3