From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gal Hammer <ghammer@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <rth@twiddle.net>,
Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL 24/28] acpi: add a missing backslash to the \_SB scope.
Date: Mon, 11 May 2015 14:48:29 +0200 [thread overview]
Message-ID: <1431329108-2605-25-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1431329108-2605-1-git-send-email-mst@redhat.com>
From: Gal Hammer <ghammer@redhat.com>
A predefined scope in the ACPI specs is precede with a backslash.
Signed-off-by: Gal Hammer <ghammer@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
include/hw/acpi/aml-build.h | 2 +-
hw/i386/acpi-build.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index 15579e6..3947201 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -146,7 +146,7 @@ void free_aml_allocator(void);
* Joins Aml elements together and helps to construct AML tables
* Examle of usage:
* Aml *table = aml_def_block("SSDT", ...);
- * Aml *sb = aml_scope("\_SB");
+ * Aml *sb = aml_scope("\\_SB");
* Aml *dev = aml_device("PCI0");
*
* aml_append(dev, aml_name_decl("HID", aml_eisaid("PNP0A03")));
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 967448a..02b2e0c 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -763,7 +763,7 @@ build_ssdt(GArray *table_data, GArray *linker,
aml_append(ssdt, scope);
}
- sb_scope = aml_scope("_SB");
+ sb_scope = aml_scope("\\_SB");
{
/* create PCI0.PRES device and its _CRS to reserve CPU hotplug MMIO */
dev = aml_device("PCI0." stringify(CPU_HOTPLUG_RESOURCE_DEVICE));
--
MST
next prev parent reply other threads:[~2015-05-11 12:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 12:46 [Qemu-devel] [PULL 00/28] pc, virtio enhancements Michael S. Tsirkin
2015-05-11 12:46 ` [Qemu-devel] [PULL 01/28] acpi-build: close } in comment Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 02/28] hw/i386: Move ACPI header definitions in an arch-independent location Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 03/28] hw/i386/acpi-build: move generic acpi building helpers into dedictated file Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 04/28] vhost-user: Send VHOST_RESET_OWNER on vhost stop Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 05/28] virtio-net: fix the upper bound when trying to delete queues Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 06/28] pc: add 2.4 machine types Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 07/28] spapr: add machine type specific instance init function Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 08/28] ppc: spapr: add 2.4 machine type Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 09/28] monitor: replace the magic number 255 with MAX_QUEUE_NUM Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 10/28] monitor: check return value of qemu_find_net_clients_except() Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 11/28] virtio-ccw: using VIRTIO_NO_VECTOR instead of 0 for invalid virtqueue Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 12/28] virtio: introduce vector to virtqueues mapping Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 13/28] virtio-pci: speedup MSI-X masking and unmasking Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 14/28] pci: remove hard-coded bar size in msix_init_exclusive_bar() Michael S. Tsirkin
2015-05-11 12:47 ` [Qemu-devel] [PULL 15/28] virtio: coding style tweak Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 16/28] docs: update documentation for memory hot unplug Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 17/28] acpi, mem-hotplug: add acpi_memory_slot_status() to get MemStatus Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 18/28] acpi, mem-hotplug: add unplug request cb for memory device Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 19/28] acpi, mem-hotplug: add unplug " Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 20/28] acpi: extend aml_field() to support UpdateRule Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 21/28] acpi: fix "Memory device control fields" register Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 22/28] acpi: add hardware implementation for memory hot unplug Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 23/28] qmp-event: add event notification for memory hot unplug error Michael S. Tsirkin
2015-05-11 15:03 ` Eric Blake
2015-05-11 15:17 ` Michael S. Tsirkin
2015-05-11 12:48 ` Michael S. Tsirkin [this message]
2015-05-11 12:48 ` [Qemu-devel] [PULL 25/28] pci: Merge pci_nic_init() into pci_nic_init_nofail() Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 26/28] virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 27/28] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi Michael S. Tsirkin
2015-05-11 12:48 ` [Qemu-devel] [PULL 28/28] acpi: update expected files for memory unplug Michael S. Tsirkin
2015-05-12 7:49 ` [Qemu-devel] [PULL 00/28] pc, virtio enhancements Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431329108-2605-25-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=ghammer@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).