From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jsnow@redhat.com
Subject: [Qemu-devel] [PULL 09/14] qtest/ahci: add migrate halted dma test
Date: Mon, 11 May 2015 14:12:38 -0400 [thread overview]
Message-ID: <1431367963-24437-10-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1431367963-24437-1-git-send-email-jsnow@redhat.com>
Test migrating a halted DMA transaction.
Resume, then test data integrity.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 1430417242-11859-10-git-send-email-jsnow@redhat.com
---
tests/ahci-test.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 74 insertions(+), 1 deletion(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index aa0db92..020acdd 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -1212,6 +1212,78 @@ static void test_halted_dma(void)
}
/**
+ * DMA Error Migration Test
+ *
+ * Simulate an error on first write, Try to write a pattern,
+ * Confirm the VM has stopped, migrate, resume the VM,
+ * verify command has completed, then read back the data and verify.
+ */
+static void test_migrate_halted_dma(void)
+{
+ AHCIQState *src, *dst;
+ uint8_t port;
+ size_t bufsize = 4096;
+ unsigned char *tx = g_malloc(bufsize);
+ unsigned char *rx = g_malloc0(bufsize);
+ unsigned i;
+ uint64_t ptr;
+ AHCICommand *cmd;
+ const char *uri = "tcp:127.0.0.1:1234";
+
+ prepare_blkdebug_script(debug_path, "write_aio");
+
+ src = ahci_boot_and_enable("-drive file=blkdebug:%s:%s,if=none,id=drive0,"
+ "format=qcow2,cache=writeback,"
+ "rerror=stop,werror=stop "
+ "-M q35 "
+ "-device ide-hd,drive=drive0 ",
+ debug_path,
+ tmp_path);
+
+ dst = ahci_boot("-drive file=%s,if=none,id=drive0,"
+ "format=qcow2,cache=writeback,"
+ "rerror=stop,werror=stop "
+ "-M q35 "
+ "-device ide-hd,drive=drive0 "
+ "-incoming %s",
+ tmp_path, uri);
+
+ set_context(src->parent);
+
+ /* Initialize and prepare */
+ port = ahci_port_select(src);
+ ahci_port_clear(src, port);
+
+ for (i = 0; i < bufsize; i++) {
+ tx[i] = (bufsize - i);
+ }
+
+ /* create DMA source buffer and write pattern */
+ ptr = ahci_alloc(src, bufsize);
+ g_assert(ptr);
+ memwrite(ptr, tx, bufsize);
+
+ /* Write, trigger the VM to stop, migrate, then resume. */
+ cmd = ahci_guest_io_halt(src, port, CMD_WRITE_DMA,
+ ptr, bufsize, 0);
+ ahci_migrate(src, dst, uri);
+ ahci_guest_io_resume(dst, cmd);
+ ahci_free(dst, ptr);
+
+ /* Read back */
+ ahci_io(dst, port, CMD_READ_DMA, rx, bufsize, 0);
+
+ /* Verify TX and RX are identical */
+ g_assert_cmphex(memcmp(tx, rx, bufsize), ==, 0);
+
+ /* Cleanup and go home. */
+ ahci_shutdown(src);
+ ahci_shutdown(dst);
+ g_free(rx);
+ g_free(tx);
+}
+
+/**
* Migration test: Try to flush, migrate, then resume.
*/
static void test_flush_migrate(void)
@@ -1511,8 +1583,9 @@ int main(int argc, char **argv)
qtest_add_func("/ahci/flush/migrate", test_flush_migrate);
qtest_add_func("/ahci/migrate/sanity", test_migrate_sanity);
- qtest_add_func("/ahci/migrate/dma", test_migrate_dma);
+ qtest_add_func("/ahci/migrate/dma/simple", test_migrate_dma);
qtest_add_func("/ahci/io/dma/lba28/retry", test_halted_dma);
+ qtest_add_func("/ahci/migrate/dma/halted", test_migrate_halted_dma);
ret = g_test_run();
--
2.1.0
next prev parent reply other threads:[~2015-05-11 18:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 18:12 [Qemu-devel] [PULL 00/14] Ide patches John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 01/14] libqos/ahci: Add halted command helpers John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 02/14] libqos/ahci: Fix sector set method John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 03/14] libqos: Add migration helpers John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 04/14] ich9/ahci: Enable Migration John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 05/14] qtest/ahci: Add migration test John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 06/14] qtest/ahci: add migrate dma test John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 07/14] qtest/ahci: add flush migrate test John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 08/14] qtest/ahci: add halted dma test John Snow
2015-05-11 18:12 ` John Snow [this message]
2015-05-11 18:12 ` [Qemu-devel] [PULL 10/14] qtest: allow arbitrarily long sends John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 11/14] qtest: Add base64 encoded read/write John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 12/14] qtest: add memset to qtest protocol John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 13/14] libqos/ahci: Swap memread/write with bufread/write John Snow
2015-05-11 18:12 ` [Qemu-devel] [PULL 14/14] qtest: pre-buffer hex nibs John Snow
2015-05-12 10:44 ` [Qemu-devel] [PULL 00/14] Ide patches Peter Maydell
2015-05-12 15:22 ` John Snow
2015-05-12 15:25 ` Peter Maydell
2015-05-12 18:53 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431367963-24437-10-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).