From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Alexander Graf <agraf@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 10/13] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11
Date: Mon, 11 May 2015 17:55:53 -0300 [thread overview]
Message-ID: <1431377756-19579-11-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1431377756-19579-1-git-send-email-ehabkost@redhat.com>
The current code setting ide-drive.ver and scsi-disk.ver on pc-0.11
breaks the PC_COMPAT_* nesting pattern we currently use.
As those variables are overwritten in pc-0.10 too, they can be inherited
by pc-0.10 with no side-effects at all.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/i386/pc_piix.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 8a94dba..69539ee 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -900,6 +900,14 @@ static QEMUMachine pc_machine_v0_12 = {
.driver = TYPE_PCI_DEVICE,\
.property = "rombar",\
.value = stringify(0),\
+ },{\
+ .driver = "ide-drive",\
+ .property = "ver",\
+ .value = "0.11",\
+ },{\
+ .driver = "scsi-disk",\
+ .property = "ver",\
+ .value = "0.11",\
},
static QEMUMachine pc_machine_v0_11 = {
@@ -907,15 +915,6 @@ static QEMUMachine pc_machine_v0_11 = {
.name = "pc-0.11",
.compat_props = (GlobalProperty[]) {
PC_COMPAT_0_11
- {
- .driver = "ide-drive",
- .property = "ver",
- .value = "0.11",
- },{
- .driver = "scsi-disk",
- .property = "ver",
- .value = "0.11",
- },
{ /* end of list */ }
},
.hw_version = "0.11",
--
2.1.0
next prev parent reply other threads:[~2015-05-11 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 20:55 [Qemu-devel] [PATCH 00/13] pc, hw, spapr: Cleanup of {HW, PC, SPAPR}_COMPAT_* macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 01/13] pc: Replace tab with spaces Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 02/13] hw: Move commas inside HW_COMPAT_2_1 macro Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 03/13] pc: Move commas inside PC_COMPAT_* macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 04/13] spapr: Move commas inside SPAPR_COMPAT_* macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 05/13] hw: Define empty HW_COMPAT_2_[23] macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 06/13] pc: Define PC_COMPAT_2_[123] macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 07/13] spapr: Use HW_COMPAT_* inside SPAPR_COMPAT_* macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 08/13] spapr: define SPAPR_COMPAT_2_3 Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 09/13] piix: Move pc-0.14 qxl compat properties to PC_COMPAT_0_14 Eduardo Habkost
2015-05-11 20:55 ` Eduardo Habkost [this message]
2015-05-11 20:55 ` [Qemu-devel] [PATCH 11/13] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13 Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 12/13] piix: Move pc-0.1[23] rombar compat props " Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 13/13] pc_piix: Define PC_COMPAT_0_10 Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431377756-19579-11-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=agraf@suse.de \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).