From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 02/13] hw: Move commas inside HW_COMPAT_2_1 macro
Date: Mon, 11 May 2015 17:55:45 -0300 [thread overview]
Message-ID: <1431377756-19579-3-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1431377756-19579-1-git-send-email-ehabkost@redhat.com>
Changing the convention to include commas inside the macros will allow
macros containing empty lists to be defined and used without compilation
errors.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/i386/pc_piix.c | 2 +-
hw/i386/pc_q35.c | 2 +-
hw/ppc/spapr.c | 2 +-
include/hw/compat.h | 2 +-
include/hw/i386/pc.h | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index b4ec3ce..0536056 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -542,7 +542,7 @@ static QEMUMachine pc_i440fx_machine_v2_1 = {
.name = "pc-i440fx-2.1",
.init = pc_init_pci_2_1,
.compat_props = (GlobalProperty[]) {
- HW_COMPAT_2_1,
+ HW_COMPAT_2_1
{ /* end of list */ }
},
};
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index dcc17c0..0248357 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -439,7 +439,7 @@ static QEMUMachine pc_q35_machine_v2_1 = {
.name = "pc-q35-2.1",
.init = pc_q35_init_2_1,
.compat_props = (GlobalProperty[]) {
- HW_COMPAT_2_1,
+ HW_COMPAT_2_1
{ /* end of list */ }
},
};
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 644689a..5f67e17 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1829,7 +1829,7 @@ static void spapr_machine_2_1_class_init(ObjectClass *oc, void *data)
{
MachineClass *mc = MACHINE_CLASS(oc);
static GlobalProperty compat_props[] = {
- HW_COMPAT_2_1,
+ HW_COMPAT_2_1
SPAPR_COMPAT_2_1,
{ /* end of list */ }
};
diff --git a/include/hw/compat.h b/include/hw/compat.h
index 313682a..c56a698 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -30,6 +30,6 @@
.driver = "virtio-pci",\
.property = "virtio-pci-bus-master-bug-migration",\
.value = "on",\
- }
+ },
#endif /* HW_COMPAT_H */
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 7ed43f1..7673a4d 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -296,7 +296,7 @@ int e820_get_num_entries(void);
bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
#define PC_COMPAT_2_0 \
- HW_COMPAT_2_1, \
+ HW_COMPAT_2_1 \
{\
.driver = "virtio-scsi-pci",\
.property = "any_layout",\
--
2.1.0
next prev parent reply other threads:[~2015-05-11 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 20:55 [Qemu-devel] [PATCH 00/13] pc, hw, spapr: Cleanup of {HW, PC, SPAPR}_COMPAT_* macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 01/13] pc: Replace tab with spaces Eduardo Habkost
2015-05-11 20:55 ` Eduardo Habkost [this message]
2015-05-11 20:55 ` [Qemu-devel] [PATCH 03/13] pc: Move commas inside PC_COMPAT_* macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 04/13] spapr: Move commas inside SPAPR_COMPAT_* macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 05/13] hw: Define empty HW_COMPAT_2_[23] macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 06/13] pc: Define PC_COMPAT_2_[123] macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 07/13] spapr: Use HW_COMPAT_* inside SPAPR_COMPAT_* macros Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 08/13] spapr: define SPAPR_COMPAT_2_3 Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 09/13] piix: Move pc-0.14 qxl compat properties to PC_COMPAT_0_14 Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 10/13] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11 Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 11/13] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13 Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 12/13] piix: Move pc-0.1[23] rombar compat props " Eduardo Habkost
2015-05-11 20:55 ` [Qemu-devel] [PATCH 13/13] pc_piix: Define PC_COMPAT_0_10 Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431377756-19579-3-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=agraf@suse.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).