From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: zhugh.fnst@cn.fujitsu.com, ehabkost@redhat.com, agraf@suse.de,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
imammedo@redhat.com, afaerber@suse.de,
david@gibson.dropbear.id.au
Subject: [Qemu-devel] [PATCH v2 0/3] Bitmap based CPU enumeration
Date: Tue, 12 May 2015 11:06:23 +0530 [thread overview]
Message-ID: <1431408986-18323-1-git-send-email-bharata@linux.vnet.ibm.com> (raw)
This patch changes the way cpu_index is handed out to newly created
CPUs by tracking the allocted CPUs in a bitmap. More information and
the need for this patch is described in patch 2/3 of this series. These
generic changes are needed to support CPU hot plug/unplug on PowerPC.
An open question is about handling of holes correctly in the allocated
bitmap to support VM migration after CPU unplug. This was briefly discussed
here:
https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg00560.html
Should cpu_exec_init() API support specifying of a particular cpu_index
in addition to returning the next available cpu_index by default ? I know
that QEMU cmdline semantics for CPU device add/delele haven't been defined
yet, but should we now make provision in cpu_exec_init() to allocate the
required cpu_index ?
Changes in v2
-------------
Following changes to address Eduardo's comments:
- Call cpu_exec_init() from generic CPU::instance_finalize() instead
of touching all archs.
- Initialize cpu_index to -1 from generic CPU::instance_init().
- Callers of cpu_exec_init() now pass error_abort argument instead of NULL.
- Consolidate the older CPU enumeration code for CONFIG_USER_ONLY under
cpu_get_free_index().
v1: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01385.html
v0: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg02950.html
Bharata B Rao (3):
cpus: Add Error argument to cpu_exec_init()
cpus: Convert cpu_index into a bitmap
ppc: Move cpu_exec_init() call to realize function
exec.c | 57 ++++++++++++++++++++++++++++++++++++++++-----
include/exec/exec-all.h | 2 +-
include/qom/cpu.h | 1 +
qom/cpu.c | 7 ++++++
target-alpha/cpu.c | 2 +-
target-arm/cpu.c | 2 +-
target-cris/cpu.c | 2 +-
target-i386/cpu.c | 2 +-
target-lm32/cpu.c | 2 +-
target-m68k/cpu.c | 2 +-
target-microblaze/cpu.c | 2 +-
target-mips/cpu.c | 2 +-
target-moxie/cpu.c | 2 +-
target-openrisc/cpu.c | 2 +-
target-ppc/translate_init.c | 9 +++++--
target-s390x/cpu.c | 2 +-
target-sh4/cpu.c | 2 +-
target-sparc/cpu.c | 2 +-
target-tricore/cpu.c | 2 +-
target-unicore32/cpu.c | 2 +-
target-xtensa/cpu.c | 2 +-
21 files changed, 83 insertions(+), 25 deletions(-)
--
2.1.0
next reply other threads:[~2015-05-12 5:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 5:36 Bharata B Rao [this message]
2015-05-12 5:36 ` [Qemu-devel] [PATCH v2 1/3] cpus: Add Error argument to cpu_exec_init() Bharata B Rao
2015-05-18 18:17 ` Eduardo Habkost
2015-05-12 5:36 ` [Qemu-devel] [PATCH v2 2/3] cpus: Convert cpu_index into a bitmap Bharata B Rao
2015-05-18 18:36 ` Eduardo Habkost
2015-05-19 6:19 ` Bharata B Rao
2015-05-19 12:14 ` Eduardo Habkost
2015-05-12 5:36 ` [Qemu-devel] [PATCH v2 3/3] ppc: Move cpu_exec_init() call to realize function Bharata B Rao
2015-05-18 19:09 ` [Qemu-devel] [PATCH v2 0/3] Bitmap based CPU enumeration Eduardo Habkost
2015-05-19 5:16 ` Bharata B Rao
2015-05-19 13:04 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431408986-18323-1-git-send-email-bharata@linux.vnet.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).