From: Gerd Hoffmann <kraxel@redhat.com>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu
Date: Tue, 12 May 2015 12:33:16 +0200 [thread overview]
Message-ID: <1431426796.26522.51.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <EAD5C449-042D-4486-9793-5E5D6C4733A6@gmail.com>
Hi,
> We *could* do it that way, but it wouldn't look pretty. Instead of having these menu items:
>
> VGA, Monitor, Serial, Parallel
>
> We would have these menu items:
>
> VGA
> compat_monitor0
> serial0
> parallel0
>
> They look very anti-pretty.
Those (except VGA) come from the chardev name. What you list here are
simply the default names qemu applies. "Serial" and "serial0" are not
that different actually, and attaching a number makes sense as you can
have multiple serial lines. Try 'qemu -serial vc -serial vc' and you'll
get another entry "serial1".
With a more verbose syntax you can have custom names for your chardevs,
try 'qemu -chardev vc,id=ttyS0 -device isa-serial,chardev=ttyS0". And
IMO it makes sense to have the actual name of the chardev show up in the
menu so you know for sure which is which.
The 'compat_monitor0' is a bit ugly indeed, IIRC this used to be just
'monitor0' but that caused some backward compatibility issues so it got
renamed this way as quick stopgap. When fixing that it would be good to
do it in the common code so it is the same for all UIs (as Peter already
sayed).
cheers,
Gerd
prev parent reply other threads:[~2015-05-12 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 0:32 [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the View menu Programmingkid
2015-05-11 13:20 ` Peter Maydell
2015-05-11 14:29 ` Programmingkid
2015-05-11 14:33 ` Peter Maydell
2015-05-11 14:38 ` Programmingkid
2015-05-11 14:49 ` Peter Maydell
2015-05-12 10:33 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431426796.26522.51.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).