From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33005)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Ys7V7-0008Fx-G9
	for qemu-devel@nongnu.org; Tue, 12 May 2015 06:33:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Ys7V2-0006nW-Hn
	for qemu-devel@nongnu.org; Tue, 12 May 2015 06:33:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42244)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Ys7V2-0006nF-C3
	for qemu-devel@nongnu.org; Tue, 12 May 2015 06:33:20 -0400
Message-ID: <1431426796.26522.51.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 12 May 2015 12:33:16 +0200
In-Reply-To: <EAD5C449-042D-4486-9793-5E5D6C4733A6@gmail.com>
References: <BE18AD69-1793-4132-BD70-1A6883167901@gmail.com>
	<CAFEAcA_HcyB8HBe_hm1yHcCwtE-qr0yEeKpOmWyXHvG7YjPcyA@mail.gmail.com>
	<EAD5C449-042D-4486-9793-5E5D6C4733A6@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4] ui/cocoa.m: Adds console items to the
 View menu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel qemu-devel <qemu-devel@nongnu.org>

  Hi,

> We *could* do it that way, but it wouldn't look pretty. Instead of having these menu items:
> 
> VGA, Monitor, Serial, Parallel
> 
> We would have these menu items:
> 
> VGA
> compat_monitor0
> serial0
> parallel0
> 
> They look very anti-pretty.

Those (except VGA) come from the chardev name.  What you list here are
simply the default names qemu applies.  "Serial" and "serial0" are not
that different actually, and attaching a number makes sense as you can
have multiple serial lines.  Try 'qemu -serial vc -serial vc' and you'll
get another entry "serial1".

With a more verbose syntax you can have custom names for your chardevs,
try 'qemu -chardev vc,id=ttyS0 -device isa-serial,chardev=ttyS0".  And
IMO it makes sense to have the actual name of the chardev show up in the
menu so you know for sure which is which.

The 'compat_monitor0' is a bit ugly indeed, IIRC this used to be just
'monitor0' but that caused some backward compatibility issues so it got
renamed this way as quick stopgap.  When fixing that it would be good to
do it in the common code so it is the same for all UIs (as Peter already
sayed).

cheers,
  Gerd