qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	pbonzini@redhat.com, jsnow@redhat.com, wangxiaolong@ucloud.cn
Subject: [Qemu-devel] [PATCH v3 6/6] iotests: Use event_wait in wait_ready
Date: Tue, 12 May 2015 19:48:35 +0800	[thread overview]
Message-ID: <1431431315-32079-7-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1431431315-32079-1-git-send-email-famz@redhat.com>

Only poll the specific type of event we are interested in, to avoid
stealing events that should be consumed by someone else.

Suggested-by: John Snow <jsnow@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
 tests/qemu-iotests/iotests.py | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 2e07cc4..0ddc513 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -328,13 +328,8 @@ class QMPTestCase(unittest.TestCase):
 
     def wait_ready(self, drive='drive0'):
         '''Wait until a block job BLOCK_JOB_READY event'''
-        ready = False
-        while not ready:
-            for event in self.vm.get_qmp_events(wait=True):
-                if event['event'] == 'BLOCK_JOB_READY':
-                    self.assert_qmp(event, 'data/type', 'mirror')
-                    self.assert_qmp(event, 'data/device', drive)
-                    ready = True
+        f = {'data': {'type': 'mirror', 'device': drive } }
+        event = self.vm.event_wait(name='BLOCK_JOB_READY', match=f)
 
     def wait_ready_and_cancel(self, drive='drive0'):
         self.wait_ready(drive=drive)
-- 
2.4.0

  parent reply	other threads:[~2015-05-12 11:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 11:48 [Qemu-devel] [PATCH v3 0/6] block: Mirror discarded sectors Fam Zheng
2015-05-12 11:48 ` [Qemu-devel] [PATCH v3 1/6] mirror: Do zero write on target if sectors not allocated Fam Zheng
2015-05-14 10:30   ` Paolo Bonzini
2015-05-14 13:52     ` Fam Zheng
2015-05-12 11:48 ` [Qemu-devel] [PATCH v3 2/6] block: Fix dirty bitmap in bdrv_co_discard Fam Zheng
2015-05-14 10:31   ` Paolo Bonzini
2015-05-12 11:48 ` [Qemu-devel] [PATCH v3 3/6] block: Remove bdrv_reset_dirty Fam Zheng
2015-05-12 11:48 ` [Qemu-devel] [PATCH v3 4/6] qemu-iotests: Make block job methods common Fam Zheng
2015-05-14 10:31   ` Paolo Bonzini
2015-05-12 11:48 ` [Qemu-devel] [PATCH v3 5/6] qemu-iotests: Add test case for mirror with unmap Fam Zheng
2015-05-14 10:37   ` Paolo Bonzini
2015-05-14 13:50     ` Fam Zheng
2015-05-12 11:48 ` Fam Zheng [this message]
2015-05-14  6:27 ` [Qemu-devel] [PATCH v3 0/6] block: Mirror discarded sectors Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431431315-32079-7-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wangxiaolong@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).