From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsEAm-0007wp-N3 for qemu-devel@nongnu.org; Tue, 12 May 2015 13:40:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsEAl-0007lg-Kd for qemu-devel@nongnu.org; Tue, 12 May 2015 13:40:52 -0400 Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:35077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsEAl-0007lb-HN for qemu-devel@nongnu.org; Tue, 12 May 2015 13:40:51 -0400 Received: by qkgy4 with SMTP id y4so10904636qkg.2 for ; Tue, 12 May 2015 10:40:51 -0700 (PDT) Received: from anchor.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id f4sm13701736qhe.9.2015.05.12.10.40.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2015 10:40:50 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Tue, 12 May 2015 10:39:47 -0700 Message-Id: <1431452387-20280-18-git-send-email-rth@twiddle.net> In-Reply-To: <1431452387-20280-1-git-send-email-rth@twiddle.net> References: <1431452387-20280-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v2 17/17] target-alpha: Rewrite helper_zapnot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The extract signed single bitfield produces significantly smaller code on x86_64. Signed-off-by: Richard Henderson --- target-alpha/int_helper.c | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/target-alpha/int_helper.c b/target-alpha/int_helper.c index 8e4537f..c023fa1 100644 --- a/target-alpha/int_helper.c +++ b/target-alpha/int_helper.c @@ -37,31 +37,25 @@ uint64_t helper_cttz(uint64_t arg) return ctz64(arg); } -static inline uint64_t byte_zap(uint64_t op, uint8_t mskb) +uint64_t helper_zapnot(uint64_t val, uint64_t mskb) { uint64_t mask; - mask = 0; - mask |= ((mskb >> 0) & 1) * 0x00000000000000FFULL; - mask |= ((mskb >> 1) & 1) * 0x000000000000FF00ULL; - mask |= ((mskb >> 2) & 1) * 0x0000000000FF0000ULL; - mask |= ((mskb >> 3) & 1) * 0x00000000FF000000ULL; - mask |= ((mskb >> 4) & 1) * 0x000000FF00000000ULL; - mask |= ((mskb >> 5) & 1) * 0x0000FF0000000000ULL; - mask |= ((mskb >> 6) & 1) * 0x00FF000000000000ULL; - mask |= ((mskb >> 7) & 1) * 0xFF00000000000000ULL; - - return op & ~mask; -} + mask = sextract64(mskb, 0, 1) & 0x00000000000000fful; + mask |= sextract64(mskb, 1, 1) & 0x000000000000ff00ul; + mask |= sextract64(mskb, 2, 1) & 0x0000000000ff0000ul; + mask |= sextract64(mskb, 3, 1) & 0x00000000ff000000ul; + mask |= sextract64(mskb, 4, 1) & 0x000000ff00000000ul; + mask |= sextract64(mskb, 5, 1) & 0x0000ff0000000000ul; + mask |= sextract64(mskb, 6, 1) & 0x00ff000000000000ul; + mask |= sextract64(mskb, 7, 1) & 0xff00000000000000ul; -uint64_t helper_zap(uint64_t val, uint64_t mask) -{ - return byte_zap(val, mask); + return val & mask; } -uint64_t helper_zapnot(uint64_t val, uint64_t mask) +uint64_t helper_zap(uint64_t val, uint64_t mask) { - return byte_zap(val, ~mask); + return helper_zapnot(val, ~mask); } uint64_t helper_cmpbge(uint64_t op1, uint64_t op2) -- 2.1.0