From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsW7F-0002sW-97 for qemu-devel@nongnu.org; Wed, 13 May 2015 08:50:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsW7C-0005vr-2G for qemu-devel@nongnu.org; Wed, 13 May 2015 08:50:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46805 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsW7B-0005vT-Sd for qemu-devel@nongnu.org; Wed, 13 May 2015 08:50:22 -0400 From: Alexander Graf Date: Wed, 13 May 2015 14:50:18 +0200 Message-Id: <1431521419-148026-3-git-send-email-agraf@suse.de> In-Reply-To: <1431521419-148026-1-git-send-email-agraf@suse.de> References: <1431521419-148026-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PULL 2/3] s390x: Add some documentation in opcode list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net I find it really hard to grasp what each field in the opcode list means. Slowly walking through its semantics myself, I figured I'd write a small summary at the top of the file to make life easier for me and whoever looks at the file next. Signed-off-by: Alexander Graf Reviewed-by: Richard Henderson --- target-s390x/insn-data.def | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index 8d8e47e..48e979e 100644 --- a/target-s390x/insn-data.def +++ b/target-s390x/insn-data.def @@ -1,3 +1,24 @@ +/* + * Arguments to the opcode prototypes + * + * C(OPC, NAME, FMT, FAC, I1, I2, P, W, OP, CC) + * D(OPC, NAME, FMT, FAC, I1, I2, P, W, OP, CC, DATA) + * + * OPC = (op << 8) | op2 where op is the major, op2 the minor opcode + * NAME = name of the opcode, used internally + * FMT = format of the opcode (defined in insn-format.def) + * FAC = facility the opcode is available in (defined in DisasFacility) + * I1 = func in1_xx fills o->in1 + * I2 = func in2_xx fills o->in2 + * P = func prep_xx initializes o->*out* + * W = func wout_xx writes o->*out* somewhere + * OP = func op_xx does the bulk of the operation + * CC = func cout_xx defines how cc should get set + * DATA = immediate argument to op_xx function + * + * The helpers get called in order: I1, I2, P, OP, W, CC + */ + /* ADD */ C(0x1a00, AR, RR_a, Z, r1, r2, new, r1_32, add, adds32) C(0xb9f8, ARK, RRF_a, DO, r2, r3, new, r1_32, add, adds32) -- 1.7.12.4