* [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value
@ 2015-05-13 13:15 Fam Zheng
2015-05-13 8:43 ` Paolo Bonzini
2015-05-28 11:17 ` Michael Tokarev
0 siblings, 2 replies; 4+ messages in thread
From: Fam Zheng @ 2015-05-13 13:15 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi
should relax.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/iscsi.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 8fca1d3..14e97a6 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1323,13 +1323,6 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
const char *filename;
int i, ret = 0;
- if ((BDRV_SECTOR_SIZE % 512) != 0) {
- error_setg(errp, "iSCSI: Invalid BDRV_SECTOR_SIZE. "
- "BDRV_SECTOR_SIZE(%lld) is not a multiple "
- "of 512", BDRV_SECTOR_SIZE);
- return -EINVAL;
- }
-
opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort);
qemu_opts_absorb_qdict(opts, options, &local_err);
if (local_err) {
--
2.4.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value
2015-05-13 13:15 [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value Fam Zheng
@ 2015-05-13 8:43 ` Paolo Bonzini
2015-05-13 8:52 ` Fam Zheng
2015-05-28 11:17 ` Michael Tokarev
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2015-05-13 8:43 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: qemu-trivial
On 13/05/2015 15:15, Fam Zheng wrote:
> raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi
> should relax.
It's okay to have the same QEMU_BUILD_BUG_ON in different places.
However, you're right that this should be a compile-time check rather
than run-time check.
Paolo
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/iscsi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 8fca1d3..14e97a6 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1323,13 +1323,6 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
> const char *filename;
> int i, ret = 0;
>
> - if ((BDRV_SECTOR_SIZE % 512) != 0) {
> - error_setg(errp, "iSCSI: Invalid BDRV_SECTOR_SIZE. "
> - "BDRV_SECTOR_SIZE(%lld) is not a multiple "
> - "of 512", BDRV_SECTOR_SIZE);
> - return -EINVAL;
> - }
> -
> opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort);
> qemu_opts_absorb_qdict(opts, options, &local_err);
> if (local_err) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value
2015-05-13 8:43 ` Paolo Bonzini
@ 2015-05-13 8:52 ` Fam Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2015-05-13 8:52 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel
On Wed, 05/13 10:43, Paolo Bonzini wrote:
>
>
> On 13/05/2015 15:15, Fam Zheng wrote:
> > raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi
> > should relax.
>
> It's okay to have the same QEMU_BUILD_BUG_ON in different places.
> However, you're right that this should be a compile-time check rather
> than run-time check.
I agree with you, but I can't imaging this value could ever change, so there is
little gain to duplicate in this case.
Fam
>
> Paolo
>
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > block/iscsi.c | 7 -------
> > 1 file changed, 7 deletions(-)
> >
> > diff --git a/block/iscsi.c b/block/iscsi.c
> > index 8fca1d3..14e97a6 100644
> > --- a/block/iscsi.c
> > +++ b/block/iscsi.c
> > @@ -1323,13 +1323,6 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
> > const char *filename;
> > int i, ret = 0;
> >
> > - if ((BDRV_SECTOR_SIZE % 512) != 0) {
> > - error_setg(errp, "iSCSI: Invalid BDRV_SECTOR_SIZE. "
> > - "BDRV_SECTOR_SIZE(%lld) is not a multiple "
> > - "of 512", BDRV_SECTOR_SIZE);
> > - return -EINVAL;
> > - }
> > -
> > opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort);
> > qemu_opts_absorb_qdict(opts, options, &local_err);
> > if (local_err) {
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value
2015-05-13 13:15 [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value Fam Zheng
2015-05-13 8:43 ` Paolo Bonzini
@ 2015-05-28 11:17 ` Michael Tokarev
1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2015-05-28 11:17 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: qemu-trivial
13.05.2015 16:15, Fam Zheng wrote:
> raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi
> should relax.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-28 11:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-13 13:15 [Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value Fam Zheng
2015-05-13 8:43 ` Paolo Bonzini
2015-05-13 8:52 ` Fam Zheng
2015-05-28 11:17 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).