From: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com,
dgilbert@redhat.com, vsementsov@parallels.com,
stefanha@redhat.com, den@openvz.org, amit.shah@redhat.com,
pbonzini@redhat.com, jsnow@redhat.com
Subject: [Qemu-devel] [PATCH 12/12] migration/qemu-file: make functions qemu_(get/put)_string public
Date: Wed, 13 May 2015 18:30:07 +0300 [thread overview]
Message-ID: <1431531007-10269-13-git-send-email-vsementsov@parallels.com> (raw)
In-Reply-To: <1431531007-10269-1-git-send-email-vsementsov@parallels.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
---
include/migration/qemu-file.h | 17 +++++++++++++++++
migration/block-dirty-bitmap.c | 35 -----------------------------------
migration/qemu-file.c | 18 ++++++++++++++++++
3 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h
index a01c5b8..cc9f29d 100644
--- a/include/migration/qemu-file.h
+++ b/include/migration/qemu-file.h
@@ -312,4 +312,21 @@ static inline void qemu_get_sbe64s(QEMUFile *f, int64_t *pv)
{
qemu_get_be64s(f, (uint64_t *)pv);
}
+
+/* read name from qemu file:
+ * format:
+ * 1 byte : len = name length (<256)
+ * len bytes : name without last zero byte
+ *
+ * name should point to the buffer >= 256 bytes length
+ */
+char *qemu_get_string(QEMUFile *f, char *name);
+
+/* write name to qemu file:
+ * format:
+ * same as for qemu_get_string
+ *
+ * maximum name length is 255
+ */
+void qemu_put_string(QEMUFile *f, const char *name);
#endif
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index 2d3ba23..3c610af 100644
--- a/migration/block-dirty-bitmap.c
+++ b/migration/block-dirty-bitmap.c
@@ -164,41 +164,6 @@ static void qemu_put_flags(QEMUFile *f, uint32_t flags)
qemu_put_be32(f, flags | DIRTY_BITMAP_MIG_FLAGS_SIZE_32);
}
-/* read name from qemu file:
- * format:
- * 1 byte : len = name length (<256)
- * len bytes : name without last zero byte
- *
- * name should point to the buffer >= 256 bytes length
- */
-static char *qemu_get_string(QEMUFile *f, char *name)
-{
- int len = qemu_get_byte(f);
- qemu_get_buffer(f, (uint8_t *)name, len);
- name[len] = '\0';
-
- DPRINTF("get name: %d %s\n", len, name);
-
- return name;
-}
-
-/* write name to qemu file:
- * format:
- * same as for qemu_get_string
- *
- * maximum name length is 255
- */
-static void qemu_put_string(QEMUFile *f, const char *name)
-{
- int len = strlen(name);
-
- DPRINTF("put name: %d %s\n", len, name);
-
- assert(len < 256);
- qemu_put_byte(f, len);
- qemu_put_buffer(f, (const uint8_t *)name, len);
-}
-
static void send_bitmap_header(QEMUFile *f, DirtyBitmapMigBitmapState *dbms,
uint32_t additional_flags)
{
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 2750365..68da16f 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -585,3 +585,21 @@ int qemu_put_qemu_file(QEMUFile *f_des, QEMUFile *f_src)
}
return len;
}
+
+char *qemu_get_string(QEMUFile *f, char *name)
+{
+ int len = qemu_get_byte(f);
+ qemu_get_buffer(f, (uint8_t *)name, len);
+ name[len] = '\0';
+
+ return name;
+}
+
+void qemu_put_string(QEMUFile *f, const char *name)
+{
+ int len = strlen(name);
+
+ assert(len < 256);
+ qemu_put_byte(f, len);
+ qemu_put_buffer(f, (const uint8_t *)name, len);
+}
--
1.9.1
next prev parent reply other threads:[~2015-05-13 16:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 15:29 [Qemu-devel] [PATCH v5 00/12] Dirty bitmaps migration Vladimir Sementsov-Ogievskiy
2015-05-13 15:29 ` [Qemu-devel] [PATCH 01/12] hbitmap: serialization Vladimir Sementsov-Ogievskiy
2015-05-13 15:29 ` [Qemu-devel] [PATCH 02/12] block: BdrvDirtyBitmap serialization interface Vladimir Sementsov-Ogievskiy
2015-05-13 15:29 ` [Qemu-devel] [PATCH 03/12] block: tiny refactoring: minimize hbitmap_(set/reset) usage Vladimir Sementsov-Ogievskiy
2015-05-13 15:29 ` [Qemu-devel] [PATCH 04/12] block: add meta bitmaps Vladimir Sementsov-Ogievskiy
2015-05-28 22:13 ` John Snow
2015-05-13 15:30 ` [Qemu-devel] [PATCH 05/12] block: add bdrv_next_dirty_bitmap() Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 06/12] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 07/12] migration: add migration/block-dirty-bitmap.c Vladimir Sementsov-Ogievskiy
2015-06-02 21:56 ` John Snow
2015-05-13 15:30 ` [Qemu-devel] [PATCH 08/12] iotests: maintain several vms in test Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 09/12] iotests: add add_incoming_migration to VM class Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 10/12] qapi: add md5 checksum of last dirty bitmap level to query-block Vladimir Sementsov-Ogievskiy
2015-05-13 15:30 ` [Qemu-devel] [PATCH 11/12] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2015-06-02 22:07 ` John Snow
2015-05-13 15:30 ` Vladimir Sementsov-Ogievskiy [this message]
2015-05-21 13:51 ` [Qemu-devel] [PATCH v5 00/12] Dirty bitmaps migration Vladimir Sementsov-Ogievskiy
2015-05-21 13:57 ` Denis V. Lunev
2015-05-21 16:44 ` John Snow
2015-05-26 14:48 ` Denis V. Lunev
2015-05-26 14:51 ` Denis V. Lunev
2015-05-28 20:09 ` John Snow
2015-05-28 20:56 ` Denis V. Lunev
2015-06-02 22:17 ` John Snow
2015-06-05 10:51 ` Denis V. Lunev
2016-01-26 8:45 ` Vladimir Sementsov-Ogievskiy
2016-01-26 22:57 ` John Snow
2016-01-27 1:17 ` Fam Zheng
2015-06-02 22:12 ` John Snow
2015-06-03 9:10 ` Vladimir Sementsov-Ogievskiy
2015-06-12 22:16 ` John Snow
2015-06-19 16:57 ` Denis V. Lunev
2015-06-19 17:38 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431531007-10269-13-git-send-email-vsementsov@parallels.com \
--to=vsementsov@parallels.com \
--cc=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).