From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH 0/2] block: Fix error code for bdrv_getlength when the image is too big
Date: Fri, 15 May 2015 09:39:09 +0800 [thread overview]
Message-ID: <1431653951-28178-1-git-send-email-famz@redhat.com> (raw)
If the image has a huge enough virtual size,
$ qemu-img info afl9.img
qemu-img: Can't get size of device 'image': Unknown error -512
It's because of the multiplication overflow in the return statement in
bdrv_getlength (the big nagetive value is later truncated to 0x200). Fix it to
return -EFBIG:
qemu-img: Can't get size of device 'image': File too large
Bug reported by Richard Jones in:
https://bugzilla.redhat.com/show_bug.cgi?id=1221499
Fam Zheng (2):
block: Detect multiplication overflow in bdrv_getlength
qemu-iotests: qemu-img info on afl VMDK image with a huge capacity
block.c | 1 +
tests/qemu-iotests/059 | 5 +++++
tests/qemu-iotests/059.out | 3 +++
tests/qemu-iotests/sample_images/afl9.vmdk.bz2 | Bin 0 -> 178 bytes
4 files changed, 9 insertions(+)
create mode 100644 tests/qemu-iotests/sample_images/afl9.vmdk.bz2
--
2.4.0
next reply other threads:[~2015-05-15 1:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 1:39 Fam Zheng [this message]
2015-05-15 1:39 ` [Qemu-devel] [PATCH 1/2] block: Detect multiplication overflow in bdrv_getlength Fam Zheng
2015-05-15 8:04 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-05-15 8:10 ` [Qemu-devel] " Markus Armbruster
2015-05-15 8:34 ` Fam Zheng
2015-05-15 1:39 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: qemu-img info on afl VMDK image with a huge capacity Fam Zheng
2015-05-15 8:06 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431653951-28178-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).