From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 09/26] qapi: Move camel_to_upper(), c_enum_const() to closely related code
Date: Fri, 15 May 2015 10:24:35 +0200 [thread overview]
Message-ID: <1431678292-17692-10-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1431678292-17692-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---
scripts/qapi.py | 50 +++++++++++++++++++++++++-------------------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 3757a91..cc33355 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -742,6 +742,31 @@ def camel_case(name):
new_name += ch.lower()
return new_name
+# ENUMName -> ENUM_NAME, EnumName1 -> ENUM_NAME1
+# ENUM_NAME -> ENUM_NAME, ENUM_NAME1 -> ENUM_NAME1, ENUM_Name2 -> ENUM_NAME2
+# ENUM24_Name -> ENUM24_NAME
+def camel_to_upper(value):
+ c_fun_str = c_name(value, False)
+ if value.isupper():
+ return c_fun_str
+
+ new_name = ''
+ l = len(c_fun_str)
+ for i in range(l):
+ c = c_fun_str[i]
+ # When c is upper and no "_" appears before, do more checks
+ if c.isupper() and (i > 0) and c_fun_str[i - 1] != "_":
+ # Case 1: next string is lower
+ # Case 2: previous string is digit
+ if (i < (l - 1) and c_fun_str[i + 1].islower()) or \
+ c_fun_str[i - 1].isdigit():
+ new_name += '_'
+ new_name += c
+ return new_name.lstrip('_').upper()
+
+def c_enum_const(type_name, const_name):
+ return camel_to_upper(type_name + '_' + const_name)
+
c_name_trans = string.maketrans('.-', '__')
def c_name(name, protect=True):
@@ -926,28 +951,3 @@ def guardend(name):
''',
name=guardname(name))
-
-# ENUMName -> ENUM_NAME, EnumName1 -> ENUM_NAME1
-# ENUM_NAME -> ENUM_NAME, ENUM_NAME1 -> ENUM_NAME1, ENUM_Name2 -> ENUM_NAME2
-# ENUM24_Name -> ENUM24_NAME
-def camel_to_upper(value):
- c_fun_str = c_name(value, False)
- if value.isupper():
- return c_fun_str
-
- new_name = ''
- l = len(c_fun_str)
- for i in range(l):
- c = c_fun_str[i]
- # When c is upper and no "_" appears before, do more checks
- if c.isupper() and (i > 0) and c_fun_str[i - 1] != "_":
- # Case 1: next string is lower
- # Case 2: previous string is digit
- if (i < (l - 1) and c_fun_str[i + 1].islower()) or \
- c_fun_str[i - 1].isdigit():
- new_name += '_'
- new_name += c
- return new_name.lstrip('_').upper()
-
-def c_enum_const(type_name, const_name):
- return camel_to_upper(type_name + '_' + const_name)
--
1.9.3
next prev parent reply other threads:[~2015-05-15 8:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 8:24 [Qemu-devel] [PULL 00/26] qapi: Fix qapi mangling of downstream names, and more Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 01/26] qmp: Add qom_path field to query-cpus command Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 02/26] doc: fix qmp event type Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 03/26] qapi: Fix C identifiers generated for names containing '.' Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 04/26] qapi: Rename identical c_fun()/c_var() into c_name() Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 05/26] qapi: Rename _generate_enum_string() to camel_to_upper() Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 06/26] qapi: Rename generate_enum_full_value() to c_enum_const() Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 07/26] qapi: Simplify c_enum_const() Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 08/26] qapi: Use c_enum_const() in generate_alternate_qtypes() Markus Armbruster
2015-05-15 8:24 ` Markus Armbruster [this message]
2015-05-15 8:24 ` [Qemu-devel] [PULL 10/26] qapi: Tidy c_type() logic Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 11/26] qapi: Make c_type() consistently convert qapi names Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 12/26] qapi: Support downstream enums Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 13/26] qapi: Support downstream structs Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 14/26] qapi: Support downstream simple unions Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 15/26] qapi: Support downstream flat unions Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 16/26] qapi: Support downstream alternates Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 17/26] qapi: Support downstream events and commands Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 18/26] tests: Add missing dependencies on $(qapi-py) Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 19/26] qapi: qapi-event.py option -b does nothing, drop it Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 20/26] qapi: qapi-commands.py option --type is unused, " Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 21/26] qapi: Factor parse_command_line() out of the generators Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 22/26] qapi: Fix generators to report command line errors decently Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 23/26] qapi: Turn generators' mandatory option -i into an argument Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 24/26] qapi: Factor open_output(), close_output() out of generators Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 25/26] qapi: Drop pointless flush() before close() Markus Armbruster
2015-05-15 8:24 ` [Qemu-devel] [PULL 26/26] qapi: Inline gen_command_decl_prologue(), gen_command_def_prologue() Markus Armbruster
2015-05-15 16:26 ` [Qemu-devel] [PULL 00/26] qapi: Fix qapi mangling of downstream names, and more Peter Maydell
2015-05-15 16:44 ` Markus Armbruster
2015-05-15 16:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431678292-17692-10-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).