From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, lersek@redhat.com,
avi.kivity@gmail.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 7/7] kvm-i386: register SMRAM regions with KVM_MEM_X86_SMRAM
Date: Fri, 15 May 2015 18:37:03 +0200 [thread overview]
Message-ID: <1431707823-51230-8-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1431707823-51230-1-git-send-email-pbonzini@redhat.com>
This patch adds SMRAM regions to the KVM CPU address space. The
/machine/smram container has KVM_MEM_X86_SMRAM set in the
memory flags, and this flag is propagated to the memory slot.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target-i386/kvm.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 09b4fc7..224f8db 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -87,6 +87,8 @@ static bool has_msr_xss;
static bool has_msr_architectural_pmu;
static uint32_t num_architectural_pmu_counters;
+static Notifier smram_machine_done;
+
bool kvm_allows_irq0_override(void)
{
return !kvm_irqchip_in_kernel() || kvm_has_gsi_routing();
@@ -846,6 +848,25 @@ static int kvm_get_supported_msrs(KVMState *s)
return ret;
}
+static void smram_notify(Notifier *n, void *unused)
+{
+ MemoryRegion *smram =
+ (MemoryRegion *) object_resolve_path("/machine/smram", NULL);
+
+ if (!smram) {
+ return;
+ }
+
+ /* Add the SMRAM regions to the KVM address space, so that they will
+ * be considered when adding memory slots.
+ *
+ * This requires that the chipsets *disables* regions in /machine/smram
+ * whenever SMRAM is opened.
+ */
+ memory_region_add_subregion_overlap(&kvm_state->kvm_as_root, 0, smram, 10);
+ smram->kvm_mem_flags |= KVM_MEM_X86_SMRAM;
+}
+
int kvm_arch_init(MachineState *ms, KVMState *s)
{
uint64_t identity_base = 0xfffbc000;
@@ -904,6 +925,12 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
return ret;
}
}
+
+ if (kvm_check_extension(s, KVM_CAP_X86_SMM)) {
+ smram_machine_done.notify = smram_notify;
+ qemu_add_machine_init_done_notifier(&smram_machine_done);
+ }
+
return 0;
}
--
1.8.3.1
prev parent reply other threads:[~2015-05-15 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 16:36 [Qemu-devel] [RFC PATCH 0/7] x86: SMRAM implementation for KVM Paolo Bonzini
2015-05-15 16:36 ` [Qemu-devel] [PATCH 1/7] kvm-all: put kvm_mem_flags to more work Paolo Bonzini
2015-05-15 16:36 ` [Qemu-devel] [PATCH 2/7] kvm-all: remove useless typedef Paolo Bonzini
2015-05-15 16:36 ` [Qemu-devel] [PATCH 3/7] kvm-all: move KVMState definitions to kvm_int.h Paolo Bonzini
2015-05-15 16:37 ` [Qemu-devel] [PATCH 4/7] kvm-all: add KVM address space Paolo Bonzini
2015-05-15 16:37 ` [Qemu-devel] [PATCH 5/7] memory: add kvm_mem_flags to MemoryRegion Paolo Bonzini
2015-05-15 16:37 ` [Qemu-devel] [PATCH 6/7] i386: disable the region in /machine/smram when SMRAM is open Paolo Bonzini
2015-05-15 16:37 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431707823-51230-8-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).