From: Gerd Hoffmann <kraxel@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
jasowang@redhat.com, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2 10/13] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11
Date: Mon, 18 May 2015 09:35:58 +0200 [thread overview]
Message-ID: <1431934558.10826.3.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1431629590-25181-11-git-send-email-ehabkost@redhat.com>
On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote:
> The current code setting ide-drive.ver and scsi-disk.ver on pc-0.11
> breaks the PC_COMPAT_* nesting pattern we currently use.
>
> As those variables are overwritten in pc-0.10 too, they can be inherited
> by pc-0.10 with no side-effects at all.
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
next prev parent reply other threads:[~2015-05-18 7:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 18:52 [Qemu-devel] [PATCH v2 00/13] pc, hw, spapr: Cleanup of {HW, PC, SPAPR}_COMPAT_* macros Eduardo Habkost
2015-05-14 18:52 ` [Qemu-devel] [PATCH v2 01/13] pc: Replace tab with spaces Eduardo Habkost
2015-05-14 18:52 ` [Qemu-devel] [PATCH v2 02/13] hw: Move commas inside HW_COMPAT_2_1 macro Eduardo Habkost
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 03/13] pc: Move commas inside PC_COMPAT_* macros Eduardo Habkost
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 04/13] spapr: Move commas inside SPAPR_COMPAT_* macros Eduardo Habkost
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 05/13] hw: Define empty HW_COMPAT_2_[23] macros Eduardo Habkost
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 06/13] pc: Define PC_COMPAT_2_[123] macros Eduardo Habkost
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 07/13] spapr: Use HW_COMPAT_* inside SPAPR_COMPAT_* macros Eduardo Habkost
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 08/13] spapr: define SPAPR_COMPAT_2_3 Eduardo Habkost
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 09/13] piix: Move pc-0.14 qxl compat properties to PC_COMPAT_0_14 Eduardo Habkost
2015-05-18 7:35 ` Gerd Hoffmann
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 10/13] piix: Move pc-0.11 drive version compat props to PC_COMPAT_0_11 Eduardo Habkost
2015-05-18 7:35 ` Gerd Hoffmann [this message]
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 11/13] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13 Eduardo Habkost
2015-05-18 7:36 ` Gerd Hoffmann
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 12/13] piix: Move pc-0.1[23] rombar compat props " Eduardo Habkost
2015-05-18 7:37 ` Gerd Hoffmann
2015-05-14 18:53 ` [Qemu-devel] [PATCH v2 13/13] piix: Define PC_COMPAT_0_10 Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431934558.10826.3.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=ehabkost@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).