From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48165)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YuFap-0003h8-1a
	for qemu-devel@nongnu.org; Mon, 18 May 2015 03:36:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YuFak-00033z-0U
	for qemu-devel@nongnu.org; Mon, 18 May 2015 03:36:06 -0400
Message-ID: <1431934558.10826.3.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 18 May 2015 09:35:58 +0200
In-Reply-To: <1431629590-25181-11-git-send-email-ehabkost@redhat.com>
References: <1431629590-25181-1-git-send-email-ehabkost@redhat.com>
	<1431629590-25181-11-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 10/13] piix: Move pc-0.11 drive version
 compat props to PC_COMPAT_0_11
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, jasowang@redhat.com, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com, rth@twiddle.net

On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote:
> The current code setting ide-drive.ver and scsi-disk.ver on pc-0.11
> breaks the PC_COMPAT_* nesting pattern we currently use.
> 
> As those variables are overwritten in pc-0.10 too, they can be inherited
> by pc-0.10 with no side-effects at all.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>