From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuFbR-0004vO-FD for qemu-devel@nongnu.org; Mon, 18 May 2015 03:36:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuFbO-0003Vs-B4 for qemu-devel@nongnu.org; Mon, 18 May 2015 03:36:45 -0400 Message-ID: <1431934598.10826.4.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 18 May 2015 09:36:38 +0200 In-Reply-To: <1431629590-25181-12-git-send-email-ehabkost@redhat.com> References: <1431629590-25181-1-git-send-email-ehabkost@redhat.com> <1431629590-25181-12-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 11/13] piix: Move pc-0.13 virtio-9p-pci compat to PC_COMPAT_0_13 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: "Michael S. Tsirkin" , jasowang@redhat.com, Alexander Graf , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, "Aneesh Kumar K.V" , pbonzini@redhat.com, rth@twiddle.net On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: > The compat property was added by commit > 9dbcca5aa13cb9ab40788ac4c56bc227d94ca920, and the pc-0.12 and older > machine-types were not changed because virtio-9p-pci was introduced on > QEMU > 0.13 (commit 9f10751365b26b13b8a9b67e0e90536ae3d282df). The only > problem is > that this breaks the PC_COMPAT_* nesting pattern we currently use. > > So, move the property to PC_COMPAT_0_13. This make pc-0.12 and older > inherit > it, but that shouldn't be an issue as QEMU 0.12 didn't have > virtio-9p-pci. Reviewed-by: Gerd Hoffmann