From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuFbv-0005kH-0N for qemu-devel@nongnu.org; Mon, 18 May 2015 03:37:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuFbr-0003kn-RX for qemu-devel@nongnu.org; Mon, 18 May 2015 03:37:14 -0400 Message-ID: <1431934627.10826.5.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 18 May 2015 09:37:07 +0200 In-Reply-To: <1431629590-25181-13-git-send-email-ehabkost@redhat.com> References: <1431629590-25181-1-git-send-email-ehabkost@redhat.com> <1431629590-25181-13-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 12/13] piix: Move pc-0.1[23] rombar compat props to PC_COMPAT_0_13 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: "Michael S. Tsirkin" , Stefan Weil , jasowang@redhat.com, Alexander Graf , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com, rth@twiddle.net On Do, 2015-05-14 at 15:53 -0300, Eduardo Habkost wrote: > The VGA and vmware-svga rombar compat properties were added by commit > 281a26b15b4adcecb8604216738975abd754bea8, but only to pc-0.13 and > pc-0.12. This breaks the PC_COMPAT_* nesting pattern we currently > follow. > > The new variables will now be inherited by pc-0.11 and older, but > pc-0.11 and pc-0.10 already have PCI.rombar=0 on compat_props, so they > shouldn't be affected at all. Reviewed-by: Gerd Hoffmann