From: hw.claudio@gmail.com
To: Luiz Capitulino <lcapitulino@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Claudio Fontana <claudio.fontana@huawei.com>,
Peter Maydell <peter.maydell@linaro.org>,
Gonglei <arei.gonglei@huawei.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC v6 0/2] monitor: add memory search commands s, sp
Date: Mon, 18 May 2015 13:22:16 +0200 [thread overview]
Message-ID: <1431948138-14238-1-git-send-email-hw.claudio@gmail.com> (raw)
From: Claudio Fontana <claudio.fontana@huawei.com>
This is the latest iteration of the memory search patch,
including a trivial replacement for the memmem function for systems
which don't provide one (notably Windows).
It detects the presence of memmem in configure and sets CONFIG_MEMMEM,
providing a trivial implementation for the !CONFIG_MEMMEM case.
The new code is MIT licensed, following usage of other files in the same
directory dealing with replacement functions (osdep, oslib, getauxval etc),
and to maximize reusability.
I have tested this in both CONFIG_MEMMEM defined/undefined scenarios,
but more feedback and testing is welcome of course.
changes from v5:
dropped the import from gnulib and implemented a trivial replacement.
changes from v4:
made into a series of two patches.
Introduced a memmem replacement function (import from gnulib)
and detection code in configure.
changes from v3:
initialize pointer variable to NULL to finally get rid of spurious warning
changes from v2:
move code to try to address spurious warning
changes from v1:
make checkpatch happy by adding braces here and there.
Claudio Fontana (2):
util: add memmem replacement function
monitor: add memory search commands s, sp
configure | 15 ++++++
hmp-commands.hx | 28 +++++++++++
include/qemu/osdep.h | 4 ++
monitor.c | 140 +++++++++++++++++++++++++++++++++++++++++++++++++++
util/Makefile.objs | 1 +
util/memmem.c | 62 +++++++++++++++++++++++
6 files changed, 250 insertions(+)
create mode 100644 util/memmem.c
--
1.8.5.3
next reply other threads:[~2015-05-18 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 11:22 hw.claudio [this message]
2015-05-18 11:22 ` [Qemu-devel] [RFC v6 1/2] util: add memmem replacement function hw.claudio
2015-05-18 14:47 ` Eric Blake
2015-05-18 11:22 ` [Qemu-devel] [RFC v6 2/2] monitor: add memory search commands s, sp hw.claudio
2015-05-28 20:18 ` [Qemu-devel] [RFC v6 0/2] " Luiz Capitulino
2015-06-11 17:53 ` Luiz Capitulino
2015-06-12 6:21 ` Markus Armbruster
2015-06-12 8:35 ` Claudio Fontana
2015-06-12 12:57 ` Markus Armbruster
2015-06-12 13:31 ` Claudio Fontana
2015-06-12 22:31 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431948138-14238-1-git-send-email-hw.claudio@gmail.com \
--to=hw.claudio@gmail.com \
--cc=arei.gonglei@huawei.com \
--cc=claudio.fontana@huawei.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).