From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: armbru@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
den@openvz.org, nshirokovskiy@virtuozzo.com
Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/accounting: introduce latency histogram
Date: Sat, 10 Mar 2018 21:10:24 -0600 [thread overview]
Message-ID: <1431d36d-2789-6fd7-0dc9-d2c2080e93e3@redhat.com> (raw)
In-Reply-To: <20180309165212.97144-2-vsementsov@virtuozzo.com>
On 03/09/2018 10:52 AM, Vladimir Sementsov-Ogievskiy wrote:
> Introduce latency histogram statics for block devices.
> For each accounted operation type latency region [0, +inf) is
Hard to read; I suggest: s/type latency/type, the latency/
> divided into subregions by several points. Then, calculate
> hits for each subregion.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> include/block/accounting.h | 35 ++++++++++++++++++
> block/accounting.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 126 insertions(+)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-11 3:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 16:52 [Qemu-devel] [PATCH v6 0/2] block latency histogram Vladimir Sementsov-Ogievskiy
2018-03-09 16:52 ` [Qemu-devel] [PATCH v6 1/2] block/accounting: introduce " Vladimir Sementsov-Ogievskiy
2018-03-11 3:10 ` Eric Blake [this message]
2018-03-09 16:52 ` [Qemu-devel] [PATCH v6 2/2] qapi: add block latency histogram interface Vladimir Sementsov-Ogievskiy
2018-03-11 3:20 ` Eric Blake
2018-03-12 8:18 ` Vladimir Sementsov-Ogievskiy
2018-03-11 3:27 ` [Qemu-devel] [PATCH v6 0/2] block latency histogram Eric Blake
2018-03-12 12:31 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431d36d-2789-6fd7-0dc9-d2c2080e93e3@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).