qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Vincenzo Maffione <v.maffione@gmail.com>,
	"Vassili Karpov (malc)" <av1474@comtv.ru>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Amit Shah <amit.shah@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
	Luigi Rizzo <rizzo@iet.unipi.it>
Subject: [Qemu-devel] [PATCH v3 11/13] xen_backend: Remove unused error handling of qemu_set_fd_handler
Date: Tue, 19 May 2015 10:51:08 +0000	[thread overview]
Message-ID: <1432032670-15124-12-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1432032670-15124-1-git-send-email-famz@redhat.com>

The function cannot fail, so the check is superfluous.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 hw/xen/xen_backend.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
index b2cb22b..2510e2e 100644
--- a/hw/xen/xen_backend.c
+++ b/hw/xen/xen_backend.c
@@ -714,9 +714,7 @@ int xen_be_init(void)
         return -1;
     }
 
-    if (qemu_set_fd_handler(xs_fileno(xenstore), xenstore_update, NULL, NULL) < 0) {
-        goto err;
-    }
+    qemu_set_fd_handler(xs_fileno(xenstore), xenstore_update, NULL, NULL);
 
     if (xen_xc == XC_HANDLER_INITIAL_VALUE) {
         /* Check if xen_init() have been called */
-- 
2.4.1

  parent reply	other threads:[~2015-05-19  2:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 10:50 [Qemu-devel] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2 Fam Zheng
2015-05-19 10:50 ` [Qemu-devel] [PATCH v3 01/13] stubs: Add qemu_set_fd_handler Fam Zheng
2015-05-19 10:50 ` [Qemu-devel] [PATCH v3 02/13] qemu-nbd: Switch to qemu_set_fd_handler Fam Zheng
2015-05-19  6:02   ` Amit Shah
2015-05-19  6:09     ` Amit Shah
2015-05-19 14:39   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 03/13] l2tpv3: Drop l2tpv3_can_send Fam Zheng
2015-05-19 14:48   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-26  6:52     ` Fam Zheng
2015-05-26  9:07       ` Stefan Hajnoczi
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 04/13] netmap: Drop netmap_can_send Fam Zheng
2015-05-19 14:54   ` Stefan Hajnoczi
2015-05-25  3:51     ` Fam Zheng
2015-05-26  9:18       ` Stefan Hajnoczi
2015-05-27  7:24         ` Fam Zheng
2015-06-02 16:24           ` Stefan Hajnoczi
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 05/13] net/socket: Drop net_socket_can_send Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 06/13] tap: Drop tap_can_send Fam Zheng
2015-06-02 16:21   ` Stefan Hajnoczi
2015-06-03  7:35     ` Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 07/13] Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 08/13] main-loop: Drop qemu_set_fd_handler2 Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 09/13] alsaaudio: Remove unused error handling of qemu_set_fd_handler Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 10/13] oss: " Fam Zheng
2015-05-19 10:51 ` Fam Zheng [this message]
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 12/13] event-notifier: Always return 0 for posix implementation Fam Zheng
2015-05-19 10:51 ` [Qemu-devel] [PATCH v3 13/13] iohandler: Change return type of qemu_set_fd_handler to "void" Fam Zheng
2015-05-19 15:02 ` [Qemu-devel] [Qemu-block] [PATCH v3 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2 Stefan Hajnoczi
2015-05-20  4:35   ` Fam Zheng
2015-05-20  6:26   ` Paolo Bonzini
2015-05-20  6:38     ` Fam Zheng
2015-05-20  7:39       ` [Qemu-devel] " Paolo Bonzini
2015-05-20  8:28         ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432032670-15124-12-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=av1474@comtv.ru \
    --cc=g.lettieri@iet.unipi.it \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rizzo@iet.unipi.it \
    --cc=stefanha@redhat.com \
    --cc=v.maffione@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).