From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuzSO-0000PW-2a for qemu-devel@nongnu.org; Wed, 20 May 2015 04:34:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuzSF-0007Ba-35 for qemu-devel@nongnu.org; Wed, 20 May 2015 04:34:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuzSE-0007BO-UM for qemu-devel@nongnu.org; Wed, 20 May 2015 04:34:19 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 3457A29321F for ; Wed, 20 May 2015 08:34:18 +0000 (UTC) From: Gerd Hoffmann Date: Wed, 20 May 2015 10:34:09 +0200 Message-Id: <1432110853-11399-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1432110853-11399-1-git-send-email-kraxel@redhat.com> References: <1432110853-11399-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 1/5] Strip brackets from vnc host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?J=C3=A1n=20Tomko?= , Gerd Hoffmann From: J=C3=A1n Tomko Commit v2.2.0-1530-ge556032 vnc: switch to inet_listen_opts bypassed the use of inet_parse in inet_listen, making literal IPv6 addresses enclosed in brackets fail: qemu-kvm: -vnc [::1]:0: Failed to start VNC server on `(null)': address resolution failed for [::1]:5900: Name or service not known Strip the brackets to make it work again. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Eric Blake Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 9f8ecd0..2dccae9 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3482,7 +3482,14 @@ void vnc_display_open(const char *id, Error **errp= ) =20 h =3D strrchr(vnc, ':'); if (h) { - char *host =3D g_strndup(vnc, h - vnc); + char *host; + size_t hlen =3D h - vnc; + + if (vnc[0] =3D=3D '[' && vnc[hlen - 1] =3D=3D ']') { + host =3D g_strndup(vnc + 1, hlen - 2); + } else { + host =3D g_strndup(vnc, hlen); + } qemu_opt_set(sopts, "host", host, &error_abort); qemu_opt_set(wsopts, "host", host, &error_abort); qemu_opt_set(sopts, "port", h+1, &error_abort); --=20 1.8.3.1