From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/5] ui: use libexpoxy
Date: Wed, 20 May 2015 17:19:38 +0200 [thread overview]
Message-ID: <1432135182-29676-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1432135182-29676-1-git-send-email-kraxel@redhat.com>
libepoxy does the opengl extension handling for us.
It also is helpful for trouble-shooting as it prints nice error messages
instead of silently failing or segfaulting in case we do something
wrong, like using gl commands not supported by the current context.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
configure | 4 ++--
include/ui/console.h | 3 +--
include/ui/shader.h | 5 +----
3 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/configure b/configure
index 1f0f485..ec67ee8 100755
--- a/configure
+++ b/configure
@@ -3153,14 +3153,14 @@ else
fi
if test "$opengl" != "no" ; then
- opengl_pkgs="gl glesv2"
+ opengl_pkgs="gl glesv2 epoxy"
if $pkg_config $opengl_pkgs x11 && test "$have_glx" = "yes"; then
opengl_cflags="$($pkg_config --cflags $opengl_pkgs) $x11_cflags"
opengl_libs="$($pkg_config --libs $opengl_pkgs) $x11_libs"
opengl=yes
else
if test "$opengl" = "yes" ; then
- feature_not_found "opengl" "Install GL devel (e.g. MESA)"
+ feature_not_found "opengl" "Please install opengl (mesa) devel pkgs: $opengl_pkgs"
fi
opengl_cflags=""
opengl_libs=""
diff --git a/include/ui/console.h b/include/ui/console.h
index e8b3a9e..383dec2 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -10,8 +10,7 @@
#include "qapi/error.h"
#ifdef CONFIG_OPENGL
-# include <GLES2/gl2.h>
-# include <GLES2/gl2ext.h>
+# include <epoxy/gl.h>
#endif
/* keyboard/mouse support */
diff --git a/include/ui/shader.h b/include/ui/shader.h
index 1ff926c..992cde6 100644
--- a/include/ui/shader.h
+++ b/include/ui/shader.h
@@ -1,7 +1,4 @@
-#ifdef CONFIG_OPENGL
-# include <GLES2/gl2.h>
-# include <GLES2/gl2ext.h>
-#endif
+#include <epoxy/gl.h>
void qemu_gl_run_texture_blit(GLint texture_blit_prog);
--
1.8.3.1
next prev parent reply other threads:[~2015-05-20 15:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:19 [Qemu-devel] [PATCH v2 0/5] gtk: add opengl support Gerd Hoffmann
2015-05-20 15:19 ` Gerd Hoffmann [this message]
2015-05-20 15:19 ` [Qemu-devel] [PATCH v2 2/5] ui: shader.h protect against double inclusion Gerd Hoffmann
2015-05-20 15:19 ` [Qemu-devel] [PATCH v2 3/5] ui: add egl-helpers Gerd Hoffmann
2015-05-23 17:36 ` Max Reitz
2015-05-20 15:19 ` [Qemu-devel] [PATCH v2 4/5] gtk: add opengl support, using egl Gerd Hoffmann
2015-05-23 17:44 ` Max Reitz
2015-05-26 6:35 ` Gerd Hoffmann
2015-05-26 12:56 ` Gerd Hoffmann
2015-05-26 14:06 ` Max Reitz
2015-05-26 14:12 ` Gerd Hoffmann
2015-05-20 15:19 ` [Qemu-devel] [PATCH v2 5/5] gtk: Replace gdk_cursor_new() Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432135182-29676-2-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).