From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv5mm-0003pY-GA for qemu-devel@nongnu.org; Wed, 20 May 2015 11:19:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv5mh-0003dm-H8 for qemu-devel@nongnu.org; Wed, 20 May 2015 11:19:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv5mh-0003dG-9f for qemu-devel@nongnu.org; Wed, 20 May 2015 11:19:51 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4KFJoHc032063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 20 May 2015 11:19:50 -0400 From: Gerd Hoffmann Date: Wed, 20 May 2015 17:19:38 +0200 Message-Id: <1432135182-29676-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1432135182-29676-1-git-send-email-kraxel@redhat.com> References: <1432135182-29676-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/5] ui: use libexpoxy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann libepoxy does the opengl extension handling for us. It also is helpful for trouble-shooting as it prints nice error messages instead of silently failing or segfaulting in case we do something wrong, like using gl commands not supported by the current context. Signed-off-by: Gerd Hoffmann Reviewed-by: Max Reitz --- configure | 4 ++-- include/ui/console.h | 3 +-- include/ui/shader.h | 5 +---- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/configure b/configure index 1f0f485..ec67ee8 100755 --- a/configure +++ b/configure @@ -3153,14 +3153,14 @@ else fi if test "$opengl" != "no" ; then - opengl_pkgs="gl glesv2" + opengl_pkgs="gl glesv2 epoxy" if $pkg_config $opengl_pkgs x11 && test "$have_glx" = "yes"; then opengl_cflags="$($pkg_config --cflags $opengl_pkgs) $x11_cflags" opengl_libs="$($pkg_config --libs $opengl_pkgs) $x11_libs" opengl=yes else if test "$opengl" = "yes" ; then - feature_not_found "opengl" "Install GL devel (e.g. MESA)" + feature_not_found "opengl" "Please install opengl (mesa) devel pkgs: $opengl_pkgs" fi opengl_cflags="" opengl_libs="" diff --git a/include/ui/console.h b/include/ui/console.h index e8b3a9e..383dec2 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -10,8 +10,7 @@ #include "qapi/error.h" #ifdef CONFIG_OPENGL -# include -# include +# include #endif /* keyboard/mouse support */ diff --git a/include/ui/shader.h b/include/ui/shader.h index 1ff926c..992cde6 100644 --- a/include/ui/shader.h +++ b/include/ui/shader.h @@ -1,7 +1,4 @@ -#ifdef CONFIG_OPENGL -# include -# include -#endif +#include void qemu_gl_run_texture_blit(GLint texture_blit_prog); -- 1.8.3.1