From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PULL 02/12] qdev: Free property names after registering gpio aliases
Date: Wed, 20 May 2015 17:51:36 +0200 [thread overview]
Message-ID: <1432137106-8295-3-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1432137106-8295-1-git-send-email-afaerber@suse.de>
From: Eduardo Habkost <ehabkost@redhat.com>
Now that object_property_add_alias() strdup()s target_name, we can free
the property names in qdev_pass_gpios().
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/core/qdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index b0f0f84..d10fa5f 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -563,6 +563,7 @@ void qdev_pass_gpios(DeviceState *dev, DeviceState *container,
object_property_add_alias(OBJECT(container), propname,
OBJECT(dev), propname,
&error_abort);
+ g_free(propname);
}
for (i = 0; i < ngl->num_out; i++) {
const char *nm = ngl->name ? ngl->name : "unnamed-gpio-out";
@@ -571,6 +572,7 @@ void qdev_pass_gpios(DeviceState *dev, DeviceState *container,
object_property_add_alias(OBJECT(container), propname,
OBJECT(dev), propname,
&error_abort);
+ g_free(propname);
}
QLIST_REMOVE(ngl, node);
QLIST_INSERT_HEAD(&container->gpios, ngl, node);
--
2.1.4
next prev parent reply other threads:[~2015-05-20 15:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:51 [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20 Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 01/12] qom: strdup() target property name on object_property_add_alias() Andreas Färber
2015-05-20 15:51 ` Andreas Färber [this message]
2015-05-20 15:51 ` [Qemu-devel] [PULL 03/12] tests: Use qtest_add_data_func() consistently Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 04/12] scripts: Add support for path as argument of qom-tree Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 05/12] backends: Fix typename of 'policy' enum property in hostmem obj Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 06/12] doc: Document user creatable object types in help text Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 07/12] vl: Create (most) objects before creating chardev backends Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 08/12] qom: Add helper method for getting user objects root Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 09/12] qom: Add object_new_with_props() / object_new_withpropv() helpers Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 10/12] qom: Make enum string tables const-correct Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 11/12] qom: Add an object_property_add_enum() helper function Andreas Färber
2015-05-20 15:51 ` [Qemu-devel] [PULL 12/12] qom: Add object_property_add_const_link() Andreas Färber
2015-05-21 11:18 ` [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20 Peter Maydell
2015-05-21 11:53 ` Daniel P. Berrange
2015-05-27 18:16 ` Andreas Färber
2015-05-29 13:51 ` Daniel P. Berrange
2015-05-29 13:57 ` Peter Maydell
2015-05-29 14:08 ` Daniel P. Berrange
2015-05-29 14:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432137106-8295-3-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).