From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yviqx-00048F-Qi for qemu-devel@nongnu.org; Fri, 22 May 2015 05:02:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yviqw-0004ng-1T for qemu-devel@nongnu.org; Fri, 22 May 2015 05:02:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yviqv-0004nY-QQ for qemu-devel@nongnu.org; Fri, 22 May 2015 05:02:49 -0400 From: Stefan Hajnoczi Date: Fri, 22 May 2015 10:01:48 +0100 Message-Id: <1432285330-13994-17-git-send-email-stefanha@redhat.com> In-Reply-To: <1432285330-13994-1-git-send-email-stefanha@redhat.com> References: <1432285330-13994-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 16/38] block/parallels: keep BAT bitmap data in little endian in memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Roman Kagan , Stefan Hajnoczi , "Denis V. Lunev" From: "Denis V. Lunev" This will allow to use this data as buffer to BAT update directly without any intermediate buffers. Signed-off-by: Denis V. Lunev Reviewed-by: Roman Kagan Reviewed-by: Stefan Hajnoczi Signed-off-by: Roman Kagan Message-id: 1430207220-24458-17-git-send-email-den@openvz.org CC: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/parallels.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 1540c21..431adf1 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -90,7 +90,6 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags, Error **errp) { BDRVParallelsState *s = bs->opaque; - int i; ParallelsHeader ph; int ret; @@ -143,10 +142,6 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags, goto fail; } - for (i = 0; i < s->bat_size; i++) { - le32_to_cpus(&s->bat_bitmap[i]); - } - s->has_truncate = bdrv_has_zero_init(bs->file) && bdrv_truncate(bs->file, bdrv_getlength(bs->file)) == 0; @@ -164,7 +159,7 @@ fail: static int64_t bat2sect(BDRVParallelsState *s, uint32_t idx) { - return (uint64_t)s->bat_bitmap[idx] * s->off_multiplier; + return (uint64_t)le32_to_cpu(s->bat_bitmap[idx]) * s->off_multiplier; } static int64_t seek_to_sector(BDRVParallelsState *s, int64_t sector_num) @@ -191,7 +186,7 @@ static int cluster_remainder(BDRVParallelsState *s, int64_t sector_num, static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num) { BDRVParallelsState *s = bs->opaque; - uint32_t idx, offset, tmp; + uint32_t idx, offset; int64_t pos; int ret; @@ -215,12 +210,10 @@ static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num) return ret; } - s->bat_bitmap[idx] = pos / s->off_multiplier; - - tmp = cpu_to_le32(s->bat_bitmap[idx]); - + s->bat_bitmap[idx] = cpu_to_le32(pos / s->off_multiplier); ret = bdrv_pwrite(bs->file, - sizeof(ParallelsHeader) + idx * sizeof(tmp), &tmp, sizeof(tmp)); + sizeof(ParallelsHeader) + idx * sizeof(s->bat_bitmap[idx]), + s->bat_bitmap + idx, sizeof(s->bat_bitmap[idx])); if (ret < 0) { s->bat_bitmap[idx] = 0; return ret; -- 2.1.0