From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvirF-0004ek-VF for qemu-devel@nongnu.org; Fri, 22 May 2015 05:03:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvirB-0004vE-Du for qemu-devel@nongnu.org; Fri, 22 May 2015 05:03:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvirB-0004v3-4d for qemu-devel@nongnu.org; Fri, 22 May 2015 05:03:05 -0400 From: Stefan Hajnoczi Date: Fri, 22 May 2015 10:01:55 +0100 Message-Id: <1432285330-13994-24-git-send-email-stefanha@redhat.com> In-Reply-To: <1432285330-13994-1-git-send-email-stefanha@redhat.com> References: <1432285330-13994-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 23/38] block/parallels: create bat_entry_off helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Roman Kagan , Stefan Hajnoczi , "Denis V. Lunev" From: "Denis V. Lunev" calculate offset of the BAT entry in the image file. Signed-off-by: Denis V. Lunev Reviewed-by: Roman Kagan Reviewed-by: Stefan Hajnoczi Signed-off-by: Roman Kagan Message-id: 1430207220-24458-24-git-send-email-den@openvz.org CC: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/parallels.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 5ff74e8..4d8a0d4 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -82,6 +82,11 @@ static int64_t bat2sect(BDRVParallelsState *s, uint32_t idx) return (uint64_t)le32_to_cpu(s->bat_bitmap[idx]) * s->off_multiplier; } +static uint32_t bat_entry_off(uint32_t idx) +{ + return sizeof(ParallelsHeader) + sizeof(uint32_t) * idx; +} + static int64_t seek_to_sector(BDRVParallelsState *s, int64_t sector_num) { uint32_t index, offset; @@ -160,9 +165,8 @@ static int64_t allocate_cluster(BlockDriverState *bs, int64_t sector_num) } s->bat_bitmap[idx] = cpu_to_le32(pos / s->off_multiplier); - ret = bdrv_pwrite(bs->file, - sizeof(ParallelsHeader) + idx * sizeof(s->bat_bitmap[idx]), - s->bat_bitmap + idx, sizeof(s->bat_bitmap[idx])); + ret = bdrv_pwrite(bs->file, bat_entry_off(idx), s->bat_bitmap + idx, + sizeof(s->bat_bitmap[idx])); if (ret < 0) { s->bat_bitmap[idx] = 0; return ret; @@ -400,8 +404,7 @@ static int parallels_create(const char *filename, QemuOpts *opts, Error **errp) } bat_entries = DIV_ROUND_UP(total_size, cl_size); - bat_sectors = DIV_ROUND_UP(bat_entries * sizeof(uint32_t) + - sizeof(ParallelsHeader), cl_size); + bat_sectors = DIV_ROUND_UP(bat_entry_off(bat_entries), cl_size); bat_sectors = (bat_sectors * cl_size) >> BDRV_SECTOR_BITS; memset(&header, 0, sizeof(header)); @@ -513,7 +516,7 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags, goto fail; } - size = sizeof(ParallelsHeader) + sizeof(uint32_t) * s->bat_size; + size = bat_entry_off(s->bat_size); s->header_size = ROUND_UP(size, bdrv_opt_mem_align(bs->file)); s->header = qemu_try_blockalign(bs->file, s->header_size); if (s->header == NULL) { -- 2.1.0