From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvirX-0005Dr-Ns for qemu-devel@nongnu.org; Fri, 22 May 2015 05:03:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvirW-00056v-1N for qemu-devel@nongnu.org; Fri, 22 May 2015 05:03:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvirV-00056U-Qt for qemu-devel@nongnu.org; Fri, 22 May 2015 05:03:25 -0400 From: Stefan Hajnoczi Date: Fri, 22 May 2015 10:02:04 +0100 Message-Id: <1432285330-13994-33-git-send-email-stefanha@redhat.com> In-Reply-To: <1432285330-13994-1-git-send-email-stefanha@redhat.com> References: <1432285330-13994-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 32/38] block: return EPERM on writes or discards to read-only devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Stefan Hajnoczi , Paolo Bonzini From: Paolo Bonzini This is the behavior in the operating system, for example Linux's blkdev_write_iter has the following: if (bdev_read_only(I_BDEV(bd_inode))) return -EPERM; This does not apply to opening a device for read/write, when the device only supports read-only operation. In this case any of EACCES, EPERM or EROFS is acceptable depending on why writing is not possible. Signed-off-by: Paolo Bonzini Message-id: 1431013548-22492-1-git-send-email-pbonzini@redhat.com Signed-off-by: Stefan Hajnoczi --- block/io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/io.c b/block/io.c index 1ce62c4..a05ad67 100644 --- a/block/io.c +++ b/block/io.c @@ -1205,7 +1205,7 @@ static int coroutine_fn bdrv_co_do_pwritev(BlockDriverState *bs, return -ENOMEDIUM; } if (bs->read_only) { - return -EACCES; + return -EPERM; } ret = bdrv_check_byte_request(bs, offset, bytes); @@ -2340,7 +2340,7 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs, int64_t sector_num, if (ret < 0) { return ret; } else if (bs->read_only) { - return -EROFS; + return -EPERM; } bdrv_reset_dirty(bs, sector_num, nb_sectors); -- 2.1.0