From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 19/20] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp()
Date: Fri, 22 May 2015 13:36:24 +0200 [thread overview]
Message-ID: <1432294585-5984-20-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1432294585-5984-1-git-send-email-armbru@redhat.com>
... and change return type to bool.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
monitor.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/monitor.c b/monitor.c
index f31a05d..2bdde35 100644
--- a/monitor.c
+++ b/monitor.c
@@ -231,8 +231,10 @@ Monitor *default_mon;
static void monitor_command_cb(void *opaque, const char *cmdline,
void *readline_opaque);
-/* Return true if in control mode, false otherwise */
-static inline int monitor_ctrl_mode(const Monitor *mon)
+/**
+ * Is @mon a QMP monitor?
+ */
+static inline bool monitor_is_qmp(const Monitor *mon)
{
return (mon->flags & MONITOR_USE_CONTROL);
}
@@ -240,7 +242,7 @@ static inline int monitor_ctrl_mode(const Monitor *mon)
/* Return non-zero iff we have a current monitor, and it is in QMP mode. */
int monitor_cur_is_qmp(void)
{
- return cur_mon && monitor_ctrl_mode(cur_mon);
+ return cur_mon && monitor_is_qmp(cur_mon);
}
void monitor_read_command(Monitor *mon, int show_prompt)
@@ -350,7 +352,7 @@ void monitor_vprintf(Monitor *mon, const char *fmt, va_list ap)
if (!mon)
return;
- if (monitor_ctrl_mode(mon)) {
+ if (monitor_is_qmp(mon)) {
return;
}
@@ -446,7 +448,7 @@ static void monitor_qapi_event_emit(QAPIEvent event, QObject *data)
trace_monitor_protocol_event_emit(event, data);
QLIST_FOREACH(mon, &mon_list, entry) {
- if (monitor_ctrl_mode(mon) && mon->qmp.in_command_mode) {
+ if (monitor_is_qmp(mon) && mon->qmp.in_command_mode) {
monitor_json_emitter(mon, data);
}
}
--
1.9.3
next prev parent reply other threads:[~2015-05-22 11:36 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 11:36 [Qemu-devel] [PATCH 00/20] monitor: Wean core off QError, and other cleanups Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 01/20] monitor: Drop broken, unused asynchronous command interface Markus Armbruster
2015-05-22 21:14 ` Eric Blake
2015-05-26 9:00 ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 02/20] monitor: Clean up after previous commit Markus Armbruster
2015-05-22 21:19 ` Eric Blake
2015-05-26 9:01 ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 03/20] monitor: Improve and document client_migrate_info protocol error Markus Armbruster
2015-05-22 21:21 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI Markus Armbruster
2015-05-22 21:43 ` Eric Blake
2015-05-26 9:16 ` Markus Armbruster
2015-05-26 12:51 ` Gerd Hoffmann
2015-05-26 12:52 ` Daniel P. Berrange
2015-05-26 14:12 ` Markus Armbruster
2015-05-26 14:15 ` Gerd Hoffmann
2015-05-26 14:55 ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 05/20] monitor: Use traditional command interface for HMP drive_del Markus Armbruster
2015-05-22 21:47 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 06/20] monitor: Use traditional command interface for HMP device_add Markus Armbruster
2015-05-22 21:56 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 07/20] monitor: Use trad. command interface for HMP pcie_aer_inject_error Markus Armbruster
2015-05-22 22:05 ` Eric Blake
2015-05-26 9:25 ` Markus Armbruster
2015-05-26 13:01 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 08/20] monitor: Drop unused "new" HMP command interface Markus Armbruster
2015-05-22 22:10 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 09/20] monitor: Propagate errors through qmp_check_client_args() Markus Armbruster
2015-05-22 22:19 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 10/20] monitor: Propagate errors through qmp_check_input_obj() Markus Armbruster
2015-05-22 22:20 ` Eric Blake
2015-05-26 9:27 ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 11/20] monitor: Wean monitor_protocol_emitter() off mon->error Markus Armbruster
2015-05-22 22:22 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 12/20] monitor: Inline monitor_has_error() into its only caller Markus Armbruster
2015-05-22 22:23 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 13/20] monitor: Limit QError use to command handlers Markus Armbruster
2015-05-22 22:38 ` Eric Blake
2015-05-26 9:45 ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 14/20] monitor: Rename handle_user_command() to handle_hmp_command() Markus Armbruster
2015-05-22 22:43 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 15/20] monitor: Rename monitor_control_read(), monitor_control_event() Markus Armbruster
2015-05-22 22:46 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 16/20] monitor: Unbox Monitor member mc and rename to qmp Markus Armbruster
2015-05-22 22:52 ` Eric Blake
2015-05-26 9:48 ` Markus Armbruster
2015-05-22 11:36 ` [Qemu-devel] [PATCH 17/20] monitor: Drop do_qmp_capabilities()'s superfluous QMP check Markus Armbruster
2015-05-22 22:53 ` Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 18/20] monitor: Turn int command_mode into bool in_command_mode Markus Armbruster
2015-05-22 22:56 ` Eric Blake
2015-05-26 9:49 ` Markus Armbruster
2015-05-22 11:36 ` Markus Armbruster [this message]
2015-05-22 22:59 ` [Qemu-devel] [PATCH 19/20] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp() Eric Blake
2015-05-22 11:36 ` [Qemu-devel] [PATCH 20/20] monitor: Change return type of monitor_cur_is_qmp() to bool Markus Armbruster
2015-05-22 23:00 ` Eric Blake
2015-05-26 9:49 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432294585-5984-20-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).