From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YxEKo-0001Vm-1I
	for qemu-devel@nongnu.org; Tue, 26 May 2015 08:51:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YxEKj-0004Ec-O1
	for qemu-devel@nongnu.org; Tue, 26 May 2015 08:51:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41152)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YxEKj-0004DW-GE
	for qemu-devel@nongnu.org; Tue, 26 May 2015 08:51:49 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4QCpmPg007900
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 26 May 2015 08:51:48 -0400
Message-ID: <1432644705.24602.8.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 26 May 2015 14:51:45 +0200
In-Reply-To: <87iobfem19.fsf@blackfin.pond.sub.org>
References: <1432294585-5984-1-git-send-email-armbru@redhat.com>
	<1432294585-5984-5-git-send-email-armbru@redhat.com>
	<555FA2E4.2000409@redhat.com> <87iobfem19.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info
 to QAPI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

  Hi,

> >> +#
> >> +# Set the spice/vnc connection info for the migration target.  The
> >> +# spice/vnc server will ask the spice/vnc client to automatically
> >> +# reconnect using the new parameters (if specified) once the vm
> >> +# migration finished successfully.  Not yet implemented for VNC.
> >> +#
> >> +# @protocol:     must be "spice"
> >> +# @hostname:     migration target hostname
> >> +# @port:         #optional spice/vnc tcp port for plaintext channels
> >
> > Is it worth documenting vnc, when we just stated earlier that protocol
> > must be spice?
> 
> I think this is a question for Gerd (cc'ed).

IIRC Daniel (added to Cc:) had plans to create a vnc extension for that.

Which was the reason to explicitly add the protocol here, so we can use
the same command for both spice and vnc some day.

> >> +##
> >> +{ 'command': 'client_migrate_info',
> >> +  'data': { 'protocol': 'str', 'hostname': 'str', '*port': 'int',
> >> +            '*tls-port': 'int', '*cert-subject': 'str' } }
> >
> > Idea for followups - since 'protocol' must be "spice", should we:
> > 1) make it an enum type rather than open-coded str
> 
> Useful cleanup.

Agree.

> > 2) make it an optional parameter, so that omitting it defaults to spice?
> 
> Not sure.  Gerd?

Not sure this buys us much.  I guess libvirt will continue to pass
'spice' because everything else doesn't make much sense.

cheers,
  Gerd