From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50866)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YxFdR-0008IX-FR
	for qemu-devel@nongnu.org; Tue, 26 May 2015 10:15:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YxFdM-000531-EC
	for qemu-devel@nongnu.org; Tue, 26 May 2015 10:15:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36093)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YxFdM-00052I-7G
	for qemu-devel@nongnu.org; Tue, 26 May 2015 10:15:08 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4QEF792006915
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 26 May 2015 10:15:07 -0400
Message-ID: <1432649704.24602.17.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 26 May 2015 16:15:04 +0200
In-Reply-To: <87lhgb4edp.fsf@blackfin.pond.sub.org>
References: <1432294585-5984-1-git-send-email-armbru@redhat.com>
	<1432294585-5984-5-git-send-email-armbru@redhat.com>
	<555FA2E4.2000409@redhat.com> <87iobfem19.fsf@blackfin.pond.sub.org>
	<1432644705.24602.8.camel@nilsson.home.kraxel.org>
	<20150526125241.GA30049@redhat.com>
	<87lhgb4edp.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info
 to QAPI
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

  Hi,

> Should we continue to document the command is about "spice/vnc
> connection info", or should we rephrase?  Something like:
> 
> client_migrate_info
> -------------------
> 
> Set remote display connection information for migration.  This makes the
> server ask the client to automatically reconnect using the new
> parameters once migration finished successfully.  Only implemented for
> SPICE.
> 
> Arguments:
> 
> - "protocol":     must be "spice" (json-string)
> - "hostname":     migration target hostname (json-string)
> - "port":         spice/vnc tcp port for plaintext channels (json-int, optional)
> - "tls-port":     spice tcp port for tls-secured channels (json-int, optional)
> - "cert-subject": server certificate subject (json-string, optional)

Looks good to me.

cheers,
  Gerd