From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxI8U-0003y3-Fn for qemu-devel@nongnu.org; Tue, 26 May 2015 12:55:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxI8T-0004W6-KH for qemu-devel@nongnu.org; Tue, 26 May 2015 12:55:26 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:37947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxI8T-0004W2-DY for qemu-devel@nongnu.org; Tue, 26 May 2015 12:55:25 -0400 Received: by wichy4 with SMTP id hy4so89293434wic.1 for ; Tue, 26 May 2015 09:55:24 -0700 (PDT) Received: from 640k.localdomain (dynamic-adsl-94-39-199-114.clienti.tiscali.it. [94.39.199.114]) by mx.google.com with ESMTPSA id x3sm17749309wiy.20.2015.05.26.09.55.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 May 2015 09:55:23 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 26 May 2015 18:54:38 +0200 Message-Id: <1432659305-54578-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1432659305-54578-1-git-send-email-pbonzini@redhat.com> References: <1432659305-54578-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v3 02/29] g364fb: remove pointless call to memory_region_set_coalescing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Coalescing work on MMIO, not RAM, thus this call has no effect. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/display/g364fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index 46f7b41..6543f2f 100644 --- a/hw/display/g364fb.c +++ b/hw/display/g364fb.c @@ -489,7 +489,6 @@ static void g364fb_init(DeviceState *dev, G364State *s) memory_region_init_ram_ptr(&s->mem_vram, NULL, "vram", s->vram_size, s->vram); vmstate_register_ram(&s->mem_vram, dev); - memory_region_set_coalescing(&s->mem_vram); } #define TYPE_G364 "sysbus-g364" -- 1.8.3.1