From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxaN7-00060y-Rt for qemu-devel@nongnu.org; Wed, 27 May 2015 08:23:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxaN2-0002sN-NU for qemu-devel@nongnu.org; Wed, 27 May 2015 08:23:45 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:28096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxaN2-0002sD-IR for qemu-devel@nongnu.org; Wed, 27 May 2015 08:23:40 -0400 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Wed, 27 May 2015 14:19:58 +0200 Message-Id: <1432729200-5322-16-git-send-email-hpoussin@reactos.org> In-Reply-To: <1432729200-5322-1-git-send-email-hpoussin@reactos.org> References: <1432729200-5322-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 15/17] net/dp8393x: fix hardware reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Leon Alrae , Aurelien Jarno Documentation is not clear of what happens when doing a hardware reset, but firmware expect all registers to be zero unless specified otherwise. This fixes reboot on MIPS Magnum. Signed-off-by: Herv=C3=A9 Poussineau --- hw/net/dp8393x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index b72b0b1..95a4d3d 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -786,6 +786,7 @@ static void dp8393x_reset(DeviceState *dev) dp8393xState *s =3D DP8393X(dev); timer_del(s->watchdog); =20 + memset(s->regs, 0, sizeof(s->regs)); s->regs[SONIC_CR] =3D SONIC_CR_RST | SONIC_CR_STP | SONIC_CR_RXDIS; s->regs[SONIC_DCR] &=3D ~(SONIC_DCR_EXBUS | SONIC_DCR_LBR); s->regs[SONIC_RCR] &=3D ~(SONIC_RCR_LB0 | SONIC_RCR_LB1 | SONIC_RCR_= BRD | SONIC_RCR_RNT); --=20 2.1.4