From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxaN8-00061G-7X for qemu-devel@nongnu.org; Wed, 27 May 2015 08:23:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxaN3-0002sd-2v for qemu-devel@nongnu.org; Wed, 27 May 2015 08:23:46 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:28115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxaN2-0002sR-Td for qemu-devel@nongnu.org; Wed, 27 May 2015 08:23:41 -0400 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Wed, 27 May 2015 14:19:59 +0200 Message-Id: <1432729200-5322-17-git-send-email-hpoussin@reactos.org> In-Reply-To: <1432729200-5322-1-git-send-email-hpoussin@reactos.org> References: <1432729200-5322-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 16/17] net/dp8393x: repair can_receive() method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Leon Alrae , Aurelien Jarno Datasheet clearly says that RXDIS flag prevents reception, but says nothing about a required presence of RXEN flag. While at it, fix the style of the following if statement. Signed-off-by: Herv=C3=A9 Poussineau --- hw/net/dp8393x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 95a4d3d..b81036a 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -622,10 +622,12 @@ static int dp8393x_can_receive(NetClientState *nc) { dp8393xState *s =3D qemu_get_nic_opaque(nc); =20 - if (!(s->regs[SONIC_CR] & SONIC_CR_RXEN)) + if (s->regs[SONIC_CR] & SONIC_CR_RXDIS) { return 0; - if (s->regs[SONIC_ISR] & SONIC_ISR_RBE) + } + if (s->regs[SONIC_ISR] & SONIC_ISR_RBE) { return 0; + } return 1; } =20 --=20 2.1.4