From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxcLZ-0000k3-Dk for qemu-devel@nongnu.org; Wed, 27 May 2015 10:30:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxcLU-0003rW-Ow for qemu-devel@nongnu.org; Wed, 27 May 2015 10:30:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxcLU-0003pG-A8 for qemu-devel@nongnu.org; Wed, 27 May 2015 10:30:12 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4REUAg0014230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 27 May 2015 10:30:11 -0400 Message-ID: <1432737007.16596.11.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 27 May 2015 16:30:07 +0200 In-Reply-To: <1432653655-30745-4-git-send-email-armbru@redhat.com> References: <1432653655-30745-1-git-send-email-armbru@redhat.com> <1432653655-30745-4-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 03/20] monitor: Improve and document client_migrate_info protocol error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com On Di, 2015-05-26 at 17:20 +0200, Markus Armbruster wrote: > Protocol must be spice, vnc isn't implemented. Fix up documentation. > > Attempts to use vnc or any other unknown protocol yield the misleading > error message "Invalid parameter 'protocol'". Improve it to > "Parameter 'protocol' expects spice". Reviewed-by. Gerd Hoffmann