qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Joao Luis Meloni Assirati <jlma@nonada.if.usp.br>
Cc: 772422@bugs.debian.org, Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, gtk-vnc-list@gnome.org
Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map
Date: Wed, 27 May 2015 16:32:00 +0200	[thread overview]
Message-ID: <1432737120.16596.13.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <55658E1E.1060608@nonada.if.usp.br>

On Mi, 2015-05-27 at 06:27 -0300, Joao Luis Meloni Assirati wrote:
> On 26-05-2015 10:58, Gerd Hoffmann wrote:
> > This patch adds the two extra brazilian keys to the evdev keymap for
> > X11.  This patch gets the two keys going with the gtk and sdl1 UIs.
> >
> > With vnc (remote-viewer) only one of the two works correctly.
> > Probably a client-side issue.  Not investigated in detail though.
> >
> > The SDL2 library complains it doesn't know these keys, so the SDL2
> > library must be fixed before we can update ui/sdl2-keymap.h
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >   ui/x_keymap.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ui/x_keymap.c b/ui/x_keymap.c
> > index b9b0944..4e899b4 100644
> > --- a/ui/x_keymap.c
> > +++ b/ui/x_keymap.c
> > @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
> >    */
> >   
> >   static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> > -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> > +    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
> >       0,         /*  98 EVDEV - KATA (Katakana) */
> >       0,         /*  99 EVDEV - HIRA (Hiragana) */
> >       0x79,      /* 100 EVDEV - HENK (Henkan) */
> > @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> >       0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
> >       0,         /* 127 EVDEV - PAUS */
> >       0,         /* 128 EVDEV - ???? */
> > -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> > +    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
> >       0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
> >       0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
> >       0x7d,      /* 132 AE13 (Yen)*/
> 
> With this patch, the / key now works.


> Unfortunately, the numpad period 
> does not work. Note that /usr/share/qemu/keymaps/pt-br lists 0x34 for 
> KP_Decimal (this is the code my patch was using), instead of 0xf0.

Which ui is this?  vnc?

What happens if you change KP_Decimal to 0xf0 in the pt-br keymap?

cheers,
  Gerd

  reply	other threads:[~2015-05-27 14:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 13:58 [Qemu-devel] [PATCH 1/2] kbd: add brazil kbd keys to qemu Gerd Hoffmann
2015-05-26 13:58 ` [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map Gerd Hoffmann
2015-05-27  9:27   ` Joao Luis Meloni Assirati
2015-05-27 14:32     ` Gerd Hoffmann [this message]
2015-05-27 19:04       ` Joao Luis Meloni Assirati
2015-05-27 11:19   ` Markus Armbruster
2015-05-27 11:35     ` Daniel P. Berrange
2015-05-27 14:39     ` Gerd Hoffmann
2015-05-27 11:40   ` Daniel P. Berrange
2015-05-27 14:42     ` Gerd Hoffmann
2015-05-28  6:24     ` Gerd Hoffmann
2015-05-28  8:52       ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432737120.16596.13.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=772422@bugs.debian.org \
    --cc=gtk-vnc-list@gnome.org \
    --cc=jlma@nonada.if.usp.br \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).