From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxcNN-0002va-8Q for qemu-devel@nongnu.org; Wed, 27 May 2015 10:32:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxcNH-0005b1-Ux for qemu-devel@nongnu.org; Wed, 27 May 2015 10:32:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxcNH-0005am-PS for qemu-devel@nongnu.org; Wed, 27 May 2015 10:32:03 -0400 Message-ID: <1432737120.16596.13.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Wed, 27 May 2015 16:32:00 +0200 In-Reply-To: <55658E1E.1060608@nonada.if.usp.br> References: <1432648685-17925-1-git-send-email-kraxel@redhat.com> <1432648685-17925-2-git-send-email-kraxel@redhat.com> <55658E1E.1060608@nonada.if.usp.br> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joao Luis Meloni Assirati Cc: 772422@bugs.debian.org, Michael Tokarev , qemu-devel@nongnu.org, gtk-vnc-list@gnome.org On Mi, 2015-05-27 at 06:27 -0300, Joao Luis Meloni Assirati wrote: > On 26-05-2015 10:58, Gerd Hoffmann wrote: > > This patch adds the two extra brazilian keys to the evdev keymap for > > X11. This patch gets the two keys going with the gtk and sdl1 UIs. > > > > With vnc (remote-viewer) only one of the two works correctly. > > Probably a client-side issue. Not investigated in detail though. > > > > The SDL2 library complains it doesn't know these keys, so the SDL2 > > library must be fixed before we can update ui/sdl2-keymap.h > > > > Signed-off-by: Gerd Hoffmann > > --- > > ui/x_keymap.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/ui/x_keymap.c b/ui/x_keymap.c > > index b9b0944..4e899b4 100644 > > --- a/ui/x_keymap.c > > +++ b/ui/x_keymap.c > > @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = { > > */ > > > > static const uint8_t evdev_keycode_to_pc_keycode[61] = { > > - 0, /* 97 EVDEV - RO ("Internet" Keyboards) */ > > + 0x73, /* 97 EVDEV - RO ("Internet" Keyboards) */ > > 0, /* 98 EVDEV - KATA (Katakana) */ > > 0, /* 99 EVDEV - HIRA (Hiragana) */ > > 0x79, /* 100 EVDEV - HENK (Henkan) */ > > @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = { > > 0, /* 126 EVDEV - I126 ("Internet" Keyboards) */ > > 0, /* 127 EVDEV - PAUS */ > > 0, /* 128 EVDEV - ???? */ > > - 0, /* 129 EVDEV - I129 ("Internet" Keyboards) */ > > + 0xf0, /* 129 EVDEV - I129 ("Internet" Keyboards) */ > > 0xf1, /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */ > > 0xf2, /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */ > > 0x7d, /* 132 AE13 (Yen)*/ > > With this patch, the / key now works. > Unfortunately, the numpad period > does not work. Note that /usr/share/qemu/keymaps/pt-br lists 0x34 for > KP_Decimal (this is the code my patch was using), instead of 0xf0. Which ui is this? vnc? What happens if you change KP_Decimal to 0xf0 in the pt-br keymap? cheers, Gerd