From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v5 0/8] qom: misc fixes & enhancements to support TLS work
Date: Wed, 27 May 2015 16:07:48 +0100 [thread overview]
Message-ID: <1432739276-10452-1-git-send-email-berrange@redhat.com> (raw)
This series contains the 7^H8 generic QOM API fixes and enhancements
that I previously posted as part of the large series refactoring
and extending the TLS support in QEMU:
https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg02038.html
I'm sending it separately, since the patches are reasonably well
self-contained and thus hopefully suitable for quicker review and
merge.
The changes in this posting are in response to Andreas' feedback
on v3.
Changed in v5:
- Fix test suite build -Wunused-value warning on some GCC versions
reported by Peter Maydell
Changed in v4:
- Introduce object_get_objects_root() to replace duplicated
container_get(object_get_root(), "/objects") calls
- Add object_set_prop[sv]()and call them to populate properties
from object_new_with_prop[sv]() constructor
- Use <programlisting> in inline docs example
- Fix naming for '...' vs 'va_list' arg method variants to
match QEMU convention (va_list one has the 'v' suffix)
- Conditionally use __attribute__((sentinel)) only on new
enough GCC (>= 4.0)
- Use a local Error * object where Error **errp could be NULL
- Change class def to use parent_obj and parent_class for
first struct member
- Use g_assert_cmpstr() in test case assertions on strings
- Other misc typos in docs, commit messages and code.
Changed in v3:
- Fix test suite additions for change in object_new_propv API
Changed in v2:
- Pass "Object * parent" instead of "char *path" paremeter
- Rely on stable reference from parent to keep new object alive
- Use object_unparent() where appropriate
Daniel P. Berrange (8):
backends: fix typename of 'policy' enum property in hostmem obj
doc: document user creatable object types in help text
vl: create (most) objects before creating chardev backends
qom: add helper method for getting user objects root
qom: add object_new_with_props / object_new_withpropv constructors
qom: make enum string tables const-correct
qom: add a object_property_add_enum helper method
qom: don't pass string table to object_get_enum method
backends/hostmem.c | 22 ++--
include/hw/qdev-core.h | 2 +-
include/qapi/util.h | 2 +-
include/qapi/visitor-impl.h | 6 +-
include/qapi/visitor.h | 2 +-
include/qemu/compiler.h | 6 +
include/qom/object.h | 163 +++++++++++++++++++++++-
iothread.c | 4 +-
numa.c | 4 +-
qapi/qapi-dealloc-visitor.c | 3 +-
qapi/qapi-util.c | 2 +-
qapi/qapi-visit-core.c | 6 +-
qemu-options.hx | 70 +++++++---
qmp.c | 6 +-
qom/object.c | 191 +++++++++++++++++++++++++++-
scripts/qapi-types.py | 4 +-
tests/.gitignore | 1 +
tests/Makefile | 5 +-
tests/check-qom-proplist.c | 302 ++++++++++++++++++++++++++++++++++++++++++++
vl.c | 40 +++++-
20 files changed, 784 insertions(+), 57 deletions(-)
create mode 100644 tests/check-qom-proplist.c
--
2.4.1
next reply other threads:[~2015-05-27 15:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 15:07 Daniel P. Berrange [this message]
2015-05-27 15:07 ` [Qemu-devel] [PATCH v5 1/8] backends: fix typename of 'policy' enum property in hostmem obj Daniel P. Berrange
2015-05-27 15:07 ` [Qemu-devel] [PATCH v5 2/8] doc: document user creatable object types in help text Daniel P. Berrange
2015-05-27 15:07 ` [Qemu-devel] [PATCH v5 3/8] vl: create (most) objects before creating chardev backends Daniel P. Berrange
2015-05-27 15:07 ` [Qemu-devel] [PATCH v5 4/8] qom: add helper method for getting user objects root Daniel P. Berrange
2015-06-19 16:41 ` Andreas Färber
2015-05-27 15:07 ` [Qemu-devel] [PATCH v5 5/8] qom: add object_new_with_props / object_new_withpropv constructors Daniel P. Berrange
2015-06-19 16:04 ` Eric Blake
2015-06-19 16:08 ` Andreas Färber
2015-06-19 16:17 ` Eric Blake
2015-06-19 16:43 ` Andreas Färber
2015-05-27 15:07 ` [Qemu-devel] [PATCH v5 6/8] qom: make enum string tables const-correct Daniel P. Berrange
2015-06-19 16:05 ` Eric Blake
2015-05-27 15:07 ` [Qemu-devel] [PATCH v5 7/8] qom: add a object_property_add_enum helper method Daniel P. Berrange
2015-06-19 16:12 ` Eric Blake
2015-06-19 16:26 ` Andreas Färber
2015-06-19 16:38 ` Eric Blake
2015-06-19 16:44 ` Andreas Färber
2015-05-27 15:07 ` [Qemu-devel] [PATCH v5 8/8] qom: don't pass string table to object_get_enum method Daniel P. Berrange
2015-06-19 15:15 ` Andreas Färber
2015-06-19 16:15 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432739276-10452-1-git-send-email-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).